-
Notifications
You must be signed in to change notification settings - Fork 1k
fix: Use model.schedule.steps -> mode._steps for batch_run #2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Performance benchmarks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Should we add a test case for this somewhere? Or add an example model to the CI that uses this?
@dylan-munson, could you install this branch and confirm it fixes your issue?
|
Hi, I tried running the pip install command but received an error message that git checkout -q fix_batch_run did not run successfully, so I am unable to try. |
Sorry, I made a mistake somewhere and was actually able to install. This did indeed fix the problem, thank you! |
I will add a test case when I have the time. For now, this is a hotfix so that people's |
@dylan-munson thank you for testing. |
Do we need a backport to 2.3 branch and a new 2.3.x. patch release? |
Ah, right, for 2.3.x only, since the |
Addresses projectmesa/mesa-examples#126