Skip to content

fix: Use model.schedule.steps -> mode._steps for batch_run #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Jul 21, 2024

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 -0.0% [-0.3%, +0.3%] 🔵 -0.8% [-1.0%, -0.6%]
Schelling large 🔵 -0.0% [-0.5%, +0.5%] 🔵 +0.6% [-1.8%, +3.2%]
WolfSheep small 🔵 +0.9% [-0.0%, +1.8%] 🔵 +1.7% [+1.4%, +2.0%]
WolfSheep large 🔵 +0.5% [+0.0%, +1.2%] 🔵 +2.0% [-0.8%, +5.0%]
BoidFlockers small 🔵 -0.2% [-1.0%, +0.5%] 🔵 -0.1% [-0.9%, +0.6%]
BoidFlockers large 🔵 +0.0% [-0.8%, +0.9%] 🔵 -0.3% [-0.9%, +0.4%]

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Should we add a test case for this somewhere? Or add an example model to the CI that uses this?

@EwoutH EwoutH added the bug Release notes label label Jul 21, 2024
@EwoutH
Copy link
Member

EwoutH commented Jul 21, 2024

@dylan-munson, could you install this branch and confirm it fixes your issue?

pip install -U -e git+https://github.com/rht/mesa@fix_batch_run#egg=mesa

@dylan-munson
Copy link

Hi, I tried running the pip install command but received an error message that git checkout -q fix_batch_run did not run successfully, so I am unable to try.

@dylan-munson
Copy link

Sorry, I made a mistake somewhere and was actually able to install. This did indeed fix the problem, thank you!

@rht
Copy link
Contributor Author

rht commented Jul 21, 2024

I will add a test case when I have the time. For now, this is a hotfix so that people's batch_run is back to be running again.

@rht
Copy link
Contributor Author

rht commented Jul 21, 2024

Sorry, I made a mistake somewhere and was actually able to install. This did indeed fix the problem, thank you!

@dylan-munson thank you for testing.

@rht rht merged commit 01477fc into projectmesa:main Jul 21, 2024
11 of 13 checks passed
@rht rht deleted the fix_batch_run branch July 21, 2024 20:38
@EwoutH
Copy link
Member

EwoutH commented Jul 21, 2024

Do we need a backport to 2.3 branch and a new 2.3.x. patch release?

@rht
Copy link
Contributor Author

rht commented Jul 21, 2024

Ah, right, for 2.3.x only, since the _steps is new since 2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants