Skip to content

remove deprecated HexGrid class #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Oct 30, 2024

This removes the long deprecated HexGrid class from mesa.space.

closes #1847

@quaquel quaquel added the maintenance Release notes label label Oct 30, 2024
@quaquel quaquel requested a review from EwoutH October 30, 2024 12:25
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔴 +7.2% [+5.6%, +8.8%] 🔵 +0.3% [+0.2%, +0.5%]
BoltzmannWealth large 🔵 -1.1% [-1.6%, -0.7%] 🔵 +2.0% [+0.7%, +3.2%]
Schelling small 🔵 +0.7% [+0.3%, +1.2%] 🔵 -0.4% [-0.8%, -0.1%]
Schelling large 🔵 +0.4% [-0.6%, +1.2%] 🔵 +1.0% [-1.7%, +3.6%]
WolfSheep small 🔵 -1.0% [-1.2%, -0.8%] 🔵 +0.1% [-0.1%, +0.4%]
WolfSheep large 🔵 -1.9% [-3.3%, -0.5%] 🔵 -1.4% [-4.4%, +1.5%]
BoidFlockers small 🔵 -0.9% [-1.4%, -0.4%] 🔵 -0.6% [-1.5%, +0.3%]
BoidFlockers large 🔵 -0.1% [-0.7%, +0.5%] 🔵 +0.3% [-0.2%, +1.0%]

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are there tests that can/need to be removed?

@quaquel
Copy link
Member Author

quaquel commented Oct 30, 2024

Looks good. Are there tests that can/need to be removed?

those would have broken and all tests pass, so no.

@quaquel quaquel merged commit 0e5abd9 into projectmesa:main Oct 30, 2024
11 of 12 checks passed
@quaquel quaquel deleted the remove_hexgrid branch October 30, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up HexSingleGrid(HexGrid) andHexGrid
2 participants