-
Notifications
You must be signed in to change notification settings - Fork 1k
Update OM 2.0 with proposal#43 Created Timestamp syntax #2636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ArthurSens
wants to merge
5
commits into
main
Choose a base branch
from
om-created-timestamps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee584fd
to
f24c2ab
Compare
krajorama
reviewed
May 30, 2025
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
77a1036
to
8d8e083
Compare
Co-authored-by: George Krajcsovits <[email protected]> Signed-off-by: Arthur Silva Sens <[email protected]>
krajorama
reviewed
Jun 3, 2025
Co-authored-by: George Krajcsovits <[email protected]> Signed-off-by: Arthur Silva Sens <[email protected]>
krajorama
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some small corrections. Also as per WG decision, you'll need another approval.
Co-authored-by: George Krajcsovits <[email protected]> Signed-off-by: Arthur Silva Sens <[email protected]>
Thanks for clarifying about exemplars :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates OpenMetrics 2.0 with our discussions in the working group and prometheus/proposals#43
cc @Maniktherana