feat(github): add check for dismissing stale PR approvals on default branch (CIS 1.1.4)#10569
Conversation
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
|
Hello @Mathisdjango! I've done a quick review, could you please remove French comments (or translate into English), add the changelog and remove the init from the tests folder? After that we'll do a deep review of the check itself. Also, if you have tested it, it would be very helpful for us if you share some screenshots of a FAIL and a PASS cases. Thanks for this and for helping improve Prowler! 🚀 |
0b89355 to
99f3df8
Compare
|
Hello! I've addressed all the requested changes : removed the comments, added the changelog entry, and removed the test init.py. I'll add the PASS/FAIL screenshots shortly. Thanks for the feedback! |
|
Hello @Mathisdjango! Thanks for your changes and for contributing! Quick comment:I’ve updated the check to evaluate and return ruleset data correctly, and I also added the corresponding compliance mapping. Also, I've tested the check and now it seems to be working as expected. 🚀 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10569 +/- ##
===========================================
- Coverage 93.51% 79.65% -13.87%
===========================================
Files 228 33 -195
Lines 32266 1268 -30998
===========================================
- Hits 30174 1010 -29164
+ Misses 2092 258 -1834
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
927be17
into
prowler-cloud:master
Description
Implements CIS Control 1.1.4 for the GitHub provider.
This check verifies that repositories are configured to automatically
dismiss stale pull request approvals when new commits are pushed,
ensuring that every code change undergoes a fresh review before merging.
Changes
dismiss_stale_reviewsfield to theBranchmodel inrepository_service.pyrepository_default_branch_dismisses_stale_reviewsTesting
Closes #8660