Skip to content

feat(entra): directory sync account exclusion#10620

Merged
danibarranqueroo merged 10 commits into
masterfrom
feat/prowler-840
Apr 14, 2026
Merged

feat(entra): directory sync account exclusion#10620
danibarranqueroo merged 10 commits into
masterfrom
feat/prowler-840

Conversation

@HugoPBrito
Copy link
Copy Markdown
Member

@HugoPBrito HugoPBrito commented Apr 8, 2026

Context

Implements a Prowler check for the Microsoft Entra Connect Sync Account exclusion scenario in Conditional Access policies.

Description

  • Adds the entra_conditional_access_policy_directory_sync_account_excluded check.
  • Evaluates enabled Conditional Access policies that target all cloud apps and all users.
  • Passes when the Directory Synchronization Accounts role is explicitly excluded.
  • Treats report-only policies as non-compliant.
  • Includes tests and compliance mapping updates.

Steps to review

  • Review the new check under prowler/providers/m365/services/entra/entra_conditional_access_policy_directory_sync_account_excluded/.
  • Review the tests under tests/providers/m365/services/entra/entra_conditional_access_policy_directory_sync_account_excluded/.
  • Review the compliance mapping update in prowler/compliance/m365/iso27001_2022_m365.json.
  • Run the relevant Entra tests locally.

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

SDK/CLI

  • Are there new checks included in this PR? Yes
    • If so, do we need to update permissions for the provider? Please review this carefully.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions Bot added compliance Issues/PRs related with the Compliance Frameworks provider/m365 Issues/PRs related with the M365 provider metadata-review labels Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Compliance Mapping Review

This PR adds new checks. Please verify that they have been mapped to the relevant compliance framework requirements.

New checks already mapped in this PR

  • entra_conditional_access_policy_directory_sync_account_excluded (m365): iso27001_2022_m365

Use the no-compliance-check label to skip this check.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

✅ All necessary CHANGELOG.md files have been updated.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.90%. Comparing base (bc3fd79) to head (01db635).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10620      +/-   ##
==========================================
- Coverage   88.07%   87.90%   -0.17%     
==========================================
  Files         125      130       +5     
  Lines        5251     5500     +249     
==========================================
+ Hits         4625     4835     +210     
- Misses        626      665      +39     
Flag Coverage Δ
prowler-py3.10-m365 87.89% <93.93%> (-0.19%) ⬇️
prowler-py3.11-m365 87.38% <93.93%> (-0.70%) ⬇️
prowler-py3.12-m365 87.89% <93.93%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 87.90% <83.93%> (-0.17%) ⬇️
api ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

🔒 Container Security Scan

Image: prowler:e5b2fce
Last scan: 2026-04-14 12:20:41 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 4
Total 4

4 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@HugoPBrito HugoPBrito changed the title PROWLER-840: MT.1020 Sync Account Exclusion feat(entra): directory sync account exclusion Apr 9, 2026
HugoPBrito and others added 5 commits April 13, 2026 14:28
- Remove quotes from status messages for the Entra sync account check
- Update the targeted SDK tests to match the new output
- Add the required SDK changelog entry for 5.24.0
- Clarify report-only status messaging for the Entra sync exclusion check
- Keep the test expectations aligned with enabled vs report-only behavior
- Remove the Maester reference from the check metadata
Updated the changelog to reflect the addition of the 'entra_conditional_access_policy_directory_sync_account_excluded' check and its ISO 27001:2022 mappings for the M365 provider.
@HugoPBrito HugoPBrito marked this pull request as ready for review April 14, 2026 08:42
@HugoPBrito HugoPBrito requested a review from a team April 14, 2026 08:42
@HugoPBrito HugoPBrito requested a review from a team as a code owner April 14, 2026 08:42
@danibarranqueroo danibarranqueroo merged commit 638bf62 into master Apr 14, 2026
35 of 36 checks passed
@danibarranqueroo danibarranqueroo deleted the feat/prowler-840 branch April 14, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compliance Issues/PRs related with the Compliance Frameworks metadata-review provider/m365 Issues/PRs related with the M365 provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants