refactor(m365): normalize CA platforms at model level#10635
Merged
danibarranqueroo merged 14 commits intoApr 14, 2026
Conversation
…platforms security check Add new security check entra_conditional_access_policy_block_unknown_device_platforms for m365 provider. Includes check implementation, metadata, and unit tests.
- Require all users and all cloud apps for compliance - Ignore policies scoped to user actions - Add regression coverage for scoped policies
- Remove the global tenant scope requirement from the check - Document Microsoft broad-scope guidance in metadata - Keep report-only policies non-compliant with Maester semantics
- Normalize Conditional Access platform values in PlatformConditions - Remove duplicated platform normalization from Entra checks - Simplify platform-based comparisons in device platform checks
This was referenced Apr 9, 2026
github-actions
Bot
added
compliance
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
github-actions
Bot
removed
the
compliance
Contributor
|
✅ All necessary |
…olicy_block_unknown_device_platforms/__init__.py
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10635 +/- ##
==========================================
- Coverage 88.07% 87.97% -0.11%
==========================================
Files 125 131 +6
Lines 5251 5537 +286
==========================================
+ Hits 4625 4871 +246
- Misses 626 666 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
HugoPBrito
added a commit
that referenced
this pull request
Apr 14, 2026
danibarranqueroo
previously approved these changes
Apr 14, 2026
HugoPBrito
force-pushed
the
refactor/entra-normalize-platforms-from-10615
branch
from
6505deb to
6c594fd
Compare
danibarranqueroo
approved these changes
Apr 14, 2026
danibarranqueroo
deleted the
refactor/entra-normalize-platforms-from-10615
branch
Contributor
🔒 Container Security ScanImage: 📊 Vulnerability Summary
4 package(s) affected
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Supersedes #10614 and now follows #10615.
Both Conditional Access checks that inspect device platforms duplicated platform normalization logic. This PR moves that normalization to the Entra model layer so checks can consume normalized platform values directly.
Description
PlatformConditionsat model construction timeentra_conditional_access_policy_block_unknown_device_platformsentra_conditional_access_policy_approved_client_app_required_for_mobileSteps to review
prowler/providers/m365/services/entra/entra_service.pyprowler/providers/m365/services/entra/Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.