fix(db): add missing tenant_id filter in queries#10722
Conversation
|
✅ All necessary |
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
🔒 Container Security ScanImage: 📊 Vulnerability Summary
4 package(s) affected
|
There was a problem hiding this comment.
Pull request overview
Fixes a potential cross-tenant data access path in Attack Paths by ensuring findings queries are scoped by tenant_id.
Changes:
- Add explicit
tenant_idfiltering when batching findings for a scan in Attack Paths ingestion. - Add a changelog entry describing the fix (currently introduces a duplicate version header).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
api/src/backend/tasks/jobs/attack_paths/findings.py |
Scopes findings batch query by tenant_id in addition to scan_id. |
api/CHANGELOG.md |
Documents the fix, but currently duplicates the 1.25.0 section header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10722 +/- ##
=======================================
Coverage 93.61% 93.61%
=======================================
Files 227 227
Lines 31899 31899
=======================================
Hits 29861 29861
Misses 2038 2038
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Description
Attack Paths: Missing
tenant_idfilter while getting related findings after scan completesChecklist
Community Checklist
SDK/CLI
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.