fix(ui): exclude muted findings and polish filter selectors#10734
Merged
alejandrobailo merged 1 commit intoApr 17, 2026
Merged
Conversation
Contributor
|
✅ All necessary |
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Contributor
🔒 Container Security ScanImage: ✅ No Vulnerabilities DetectedThe container image passed all security checks. No known CVEs were found.📋 Resources:
|
ec4d4f4 to
b959584
Compare
- Exclude muted findings by default in resource detail drawer and finding group resource views - MultiSelect shows the category label as context (e.g. 'Status: FAIL') when filters are applied instead of hiding the placeholder - Add optional 'wide' width to FilterOption and data-table-filter-custom; apply 'wide' to the findings Scan filter to prevent label truncation - Update providers filter to honor the new width option
429c5d2 to
d450bd3
Compare
7 tasks
Collaborator
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fix PROWLER-1401
Findings and filter UX fixes kept in this PR as a backport. The Compliance page redesign that was originally part of this branch has been moved to a separate PR: #10767.
Description
getLatestFindingsByResourceUidexcludes muted findings by default; group-resource drawer and finding-group resource hook opt in explicitly viaincludeMutedInOtherFindingsonly where needed, so muted findings no longer appear in the resource detail drawer or overview.Status: FAIL) instead of hiding the placeholder entirely.widthoption — new optionalwidth?: "default" | "wide"onFilterOption, wired throughDataTableFilterCustomandProvidersFilters. The findings Scan filter opts in to"wide"to prevent label truncation on long scan names.Steps to review
ui/actions/findings/findings-by-resource.ts:includeMuteddefaults tofalse; check thatgetLatestFindingsByResourceUidno longer returns muted findings unless the caller asks.ui/components/findings/table/resource-detail-drawer/use-resource-detail-drawer.ts:includeMutedInOtherFindingsoption flows through the drawer correctly.ui/hooks/use-finding-group-resource-state.ts: verify the muted opt-in is honored.ui/components/shadcn/select/multiselect.tsx: regex logic for extracting the category label fromAll Xplaceholders.ui/types/filters.ts(newwidthfield),ui/components/ui/table/data-table-filter-custom.tsx,ui/components/providers/providers-filters.tsx(consumers),ui/components/findings/findings-filters.tsx(Scan filter opts in to"wide").ui/actions/findings/findings-by-resource.test.ts,ui/components/findings/table/resource-detail-drawer/use-resource-detail-drawer.test.ts,ui/hooks/use-finding-group-resource-state.test.ts,ui/components/shadcn/select/multiselect.test.tsx, andui/components/ui/table/data-table-filter-custom-batch.test.tsx.ui/CHANGELOG.mdentry under1.24.1/🐞 Fixed.Checklist
UI
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.