Skip to content

fix(ui): exclude muted findings and polish filter selectors#10734

Merged
alejandrobailo merged 1 commit into
masterfrom
refactor/improve-findings-and-compliance-ui-behavior
Apr 17, 2026
Merged

fix(ui): exclude muted findings and polish filter selectors#10734
alejandrobailo merged 1 commit into
masterfrom
refactor/improve-findings-and-compliance-ui-behavior

Conversation

@alejandrobailo
Copy link
Copy Markdown
Contributor

@alejandrobailo alejandrobailo commented Apr 16, 2026

Context

Fix PROWLER-1401

Findings and filter UX fixes kept in this PR as a backport. The Compliance page redesign that was originally part of this branch has been moved to a separate PR: #10767.

Description

  • Muted findings excluded by defaultgetLatestFindingsByResourceUid excludes muted findings by default; group-resource drawer and finding-group resource hook opt in explicitly via includeMutedInOtherFindings only where needed, so muted findings no longer appear in the resource detail drawer or overview.
  • MultiSelect context label — when filters are applied, the trigger shows the category label (for example Status: FAIL) instead of hiding the placeholder entirely.
  • Filter dropdown width option — new optional width?: "default" | "wide" on FilterOption, wired through DataTableFilterCustom and ProvidersFilters. The findings Scan filter opts in to "wide" to prevent label truncation on long scan names.

Steps to review

  1. Muted findings server actionui/actions/findings/findings-by-resource.ts: includeMuted defaults to false; check that getLatestFindingsByResourceUid no longer returns muted findings unless the caller asks.
  2. Resource detail drawerui/components/findings/table/resource-detail-drawer/use-resource-detail-drawer.ts: includeMutedInOtherFindings option flows through the drawer correctly.
  3. Finding-group resource stateui/hooks/use-finding-group-resource-state.ts: verify the muted opt-in is honored.
  4. MultiSelect labelui/components/shadcn/select/multiselect.tsx: regex logic for extracting the category label from All X placeholders.
  5. Filter width optionui/types/filters.ts (new width field), ui/components/ui/table/data-table-filter-custom.tsx, ui/components/providers/providers-filters.tsx (consumers), ui/components/findings/findings-filters.tsx (Scan filter opts in to "wide").
  6. Tests — new/updated assertions across ui/actions/findings/findings-by-resource.test.ts, ui/components/findings/table/resource-detail-drawer/use-resource-detail-drawer.test.ts, ui/hooks/use-finding-group-resource-state.test.ts, ui/components/shadcn/select/multiselect.test.tsx, and ui/components/ui/table/data-table-filter-custom-batch.test.tsx.
  7. Changelogui/CHANGELOG.md entry under 1.24.1 / 🐞 Fixed.

Checklist

  • Review if the code is being covered by tests.
  • Review if backport is needed.

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alejandrobailo alejandrobailo requested a review from a team as a code owner April 16, 2026 11:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

🔒 Container Security Scan

Image: prowler-ui:6b54c9d
Last scan: 2026-04-17 08:20:59 UTC

✅ No Vulnerabilities Detected

The container image passed all security checks. No known CVEs were found.

📋 Resources:

@alejandrobailo alejandrobailo added the backport-to-v5.24 Backport PR to the v5.24 branch label Apr 16, 2026
@alejandrobailo alejandrobailo self-assigned this Apr 16, 2026
@alejandrobailo alejandrobailo force-pushed the refactor/improve-findings-and-compliance-ui-behavior branch from ec4d4f4 to b959584 Compare April 17, 2026 07:22
- Exclude muted findings by default in resource detail drawer and finding group resource views
- MultiSelect shows the category label as context (e.g. 'Status: FAIL') when filters are applied instead of hiding the placeholder
- Add optional 'wide' width to FilterOption and data-table-filter-custom; apply 'wide' to the findings Scan filter to prevent label truncation
- Update providers filter to honor the new width option
@alejandrobailo alejandrobailo force-pushed the refactor/improve-findings-and-compliance-ui-behavior branch from 429c5d2 to d450bd3 Compare April 17, 2026 08:15
@alejandrobailo alejandrobailo changed the title refactor(ui): improve Findings and Compliance UI behavior fix(ui): exclude muted findings and polish filter selectors Apr 17, 2026
Copy link
Copy Markdown
Contributor

@pfe-nazaries pfe-nazaries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alejandrobailo alejandrobailo merged commit f2d35f5 into master Apr 17, 2026
39 checks passed
@alejandrobailo alejandrobailo deleted the refactor/improve-findings-and-compliance-ui-behavior branch April 17, 2026 09:07
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Apr 17, 2026
@prowler-bot
Copy link
Copy Markdown
Collaborator

💚 All backports created successfully

Status Branch Result
v5.24

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v5.24 Backport PR to the v5.24 branch component/ui was-backported The PR was successfully backported to the target branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants