Skip to content

chore(ui): unify filter search and batch patterns#10859

Merged
alejandrobailo merged 5 commits into
masterfrom
chore/unify-filter-search-and-batch-patterns
Apr 23, 2026
Merged

chore(ui): unify filter search and batch patterns#10859
alejandrobailo merged 5 commits into
masterfrom
chore/unify-filter-search-and-batch-patterns

Conversation

@alejandrobailo
Copy link
Copy Markdown
Contributor

@alejandrobailo alejandrobailo commented Apr 22, 2026

Context

Resource filters need to converge on the same interaction model already used in findings. Before touching the Resources view, the shared filter primitives needed to support local option search and predictable dropdown behavior across the app.

Screen.Recording.2026-04-23.at.14.20.57.mov

Description

This PR updates the shared filter building blocks used by table and provider filters.

  • enable local option search in shared multiselect dropdowns
  • keep the trigger value stable while the dropdown search input is active
  • auto-scroll to the first visible match when filtering long option lists
  • wire the shared behavior into table filters and provider filters
  • keep the change UI-only: no backend contract, URL shape, or query param semantics change

Steps to review

  1. Open any findings view with multi-select filters and search inside a long dropdown.
  2. Confirm the selected value shown in the trigger does not change while typing in the dropdown search input.
  3. Confirm the list scrolls to the first visible match when the typed query narrows the options.
  4. Open Cloud Providers and verify the same searchable dropdown behavior is available there.
  5. Run:
    • cd ui && pnpm test:run components/shadcn/select/multiselect.test.tsx components/ui/table/data-table-filter-custom-batch.test.tsx components/providers/providers-filters.test.tsx
    • cd ui && pnpm typecheck

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

SDK/CLI

  • Are there new checks included in this PR? No
    • If so, do we need to update permissions for the provider? Please review this carefully.

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • All issue/task requirements work as expected on the API
  • Endpoint response output (if applicable)
  • EXPLAIN ANALYZE output for new/modified queries or indexes (if applicable)
  • Performance test results (if applicable)
  • Any other relevant evidence of the implementation (if applicable)
  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- enable searchable shared filter dropdowns
- scroll to the first visible match while filtering
- cover provider and table filters with tests
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

✅ All necessary CHANGELOG.md files have been updated.

@alejandrobailo alejandrobailo self-assigned this Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

🔒 Container Security Scan

Image: prowler-ui:07f8e4f
Last scan: 2026-04-23 12:25:20 UTC

✅ No Vulnerabilities Detected

The container image passed all security checks. No known CVEs were found.

📋 Resources:

@alejandrobailo alejandrobailo marked this pull request as ready for review April 23, 2026 11:56
@alejandrobailo alejandrobailo requested a review from a team as a code owner April 23, 2026 11:56
@pfe-nazaries pfe-nazaries self-requested a review April 23, 2026 12:57
@alejandrobailo alejandrobailo merged commit d877bea into master Apr 23, 2026
38 checks passed
@alejandrobailo alejandrobailo deleted the chore/unify-filter-search-and-batch-patterns branch April 23, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants