Skip to content

fix(cli): generate compliance after scan #10919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfagoagas merged 2 commits into from
Apr 28, 2026
Merged

fix(cli): generate compliance after scan #10919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23bbba3
fix(cli): generate compliance after scan
jfagoagas Apr 28, 2026
d0a7d25
chore: add changelog #
jfagoagas Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions prowler/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ All notable changes to the **Prowler SDK** are documented in this file.

---

## [5.25.1] (Prowler v5.25.1)

### 🐞 Fixed

- `KeyError` when generating compliance outputs after the CLI scan [#10919](https://github.com/prowler-cloud/prowler/pull/10919)

---

## [5.25.0] (Prowler v5.25.0)

### 🚀 Added
Expand Down
8 changes: 7 additions & 1 deletion prowler/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,8 +624,14 @@ def streaming_callback(findings_batch):
)

# Compliance Frameworks
# Source the framework listing from `bulk_compliance_frameworks.keys()`
# so it is by construction a subset of what the bulk loader can resolve.
# `get_available_compliance_frameworks(provider)` also discovers top-level
# multi-provider universal JSONs (e.g. `prowler/compliance/csa_ccm_4.0.json`)
# which `Compliance.get_bulk(provider)` does not load, and which the legacy
# output handlers below cannot consume — using it as the source produced
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanatory comment ends mid-sentence ("using it as the source produced"), which makes the rationale unclear. Please complete/reword this comment so it clearly states the failure mode being prevented (e.g., the KeyError from universal/top-level frameworks not present in bulk_compliance_frameworks).

Suggested change
# output handlers below cannot consume — using it as the source produced
# output handlers below cannot consume. Using that broader list here could
# include framework names not present in `bulk_compliance_frameworks`,
# causing a `KeyError` when the handlers later index by `compliance_name`.

Copilot uses AI. Check for mistakes.
input_compliance_frameworks = set(output_options.output_modes).intersection(
get_available_compliance_frameworks(provider)
bulk_compliance_frameworks.keys()
)
Comment thread
jfagoagas marked this conversation as resolved.
if provider == "aws":
for compliance_name in input_compliance_frameworks:
Expand Down
Loading