Skip to content

fix(azure): update flow log compliance text for NSG retirement#10937

Merged
danibarranqueroo merged 2 commits into
prowler-cloud:masterfrom
davletd:fix/azure-cis-flow-log-retirement-guidance
Apr 29, 2026
Merged

fix(azure): update flow log compliance text for NSG retirement#10937
danibarranqueroo merged 2 commits into
prowler-cloud:masterfrom
davletd:fix/azure-cis-flow-log-retirement-guidance

Conversation

@davletd
Copy link
Copy Markdown
Contributor

@davletd davletd commented Apr 29, 2026

Context

Fix #10936

PR #10645 fixed the Azure Network Watcher flow log check behavior and generic check metadata. After that merge, some Azure compliance mappings still contained stale flow-log text for the legacy controls.

The remaining problem is compliance-content specific: several Azure entries still tell users to create or inspect NSG flow logs directly, including old NSG-only portal steps, az network watcher flow-log configure --nsg ... examples, or NSG-only control wording. That guidance is misleading now that Azure stopped allowing creation of new NSG flow logs after June 30, 2025 and is retiring them on September 30, 2027.

This PR keeps the control mappings intact and updates only the Azure compliance text.

Description

  • update the Azure CIS remediation text for the legacy network_flow_log_captured_sent mappings so it is retirement-aware and points new or migrated deployments to Virtual network flow logs
  • update the Azure CIS audit text for the same mappings so it no longer implies an NSG-only review path
  • update the Azure CIS remediation and audit text for the legacy network_flow_log_more_than_90_days mappings to remove deprecated --nsg CLI guidance and reflect current flow log migration guidance
  • update prowler_threatscore_azure.json so the custom flow-log narrative uses Network Watcher / supported-target wording instead of NSG-only wording and reflects the current retention logic
  • add an SDK changelog entry for the compliance-text cleanup

Steps to review

  1. Review the Azure compliance updates in:

    • prowler/compliance/azure/cis_2.0_azure.json
    • prowler/compliance/azure/cis_2.1_azure.json
    • prowler/compliance/azure/cis_3.0_azure.json
    • prowler/compliance/azure/cis_4.0_azure.json
    • prowler/compliance/azure/cis_5.0_azure.json
    • prowler/compliance/azure/prowler_threatscore_azure.json
  2. Confirm the legacy NSG benchmark entries now:

    • keep the original benchmark control mapping/title where required by the source benchmark
    • clarify that existing NSG flow logs may still be reviewed until migration is complete
    • direct new or migrated deployments to Virtual network flow logs
    • remove deprecated NSG-only remediation steps such as az network watcher flow-log configure --nsg ...
  3. Confirm the ThreatScore flow-log entries now:

    • use Network Watcher flow logs wording instead of Network Security Group Flow logs
    • refer to supported targets such as virtual networks and network security groups
    • reflect retention logic of 0 or at least 90 days
  4. Confirm the SDK changelog entry in prowler/CHANGELOG.md.

  5. Validate JSON syntax:

    python3 - <<'PY'
    import json, pathlib
    for p in sorted(pathlib.Path('prowler/compliance/azure').glob('*.json')):
    json.load(open(p))
    print('json-ok')
    PY

Expected result: json-ok.

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

SDK/CLI

  • Are there new checks included in this PR? No

UI

  • Not applicable.

API

  • Not applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@davletd davletd requested review from a team as code owners April 29, 2026 12:59
@github-actions github-actions Bot added the compliance Issues/PRs related with the Compliance Frameworks label Apr 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions github-actions Bot added the community Opened by the Community label Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.17%. Comparing base (7076900) to head (1fce68d).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10937       +/-   ##
===========================================
+ Coverage   69.01%   86.17%   +17.16%     
===========================================
  Files         104      223      +119     
  Lines        7596     5744     -1852     
===========================================
- Hits         5242     4950      -292     
+ Misses       2354      794     -1560     
Flag Coverage Δ
prowler-py3.10-azure 86.17% <ø> (?)
prowler-py3.10-lib ?
prowler-py3.11-azure 86.17% <ø> (?)
prowler-py3.11-lib ?
prowler-py3.12-azure 86.17% <ø> (?)
prowler-py3.12-lib ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 86.17% <ø> (+17.16%) ⬆️
api ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davletd davletd changed the title fix(azure): update CIS flow log remediation text for NSG retirement fix(azure): update flow log compliance text for NSG retirement Apr 29, 2026
Copy link
Copy Markdown
Member

@danibarranqueroo danibarranqueroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 💯

Copy link
Copy Markdown
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I love it 🥇

@danibarranqueroo danibarranqueroo merged commit dd37f4e into prowler-cloud:master Apr 29, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Opened by the Community compliance Issues/PRs related with the Compliance Frameworks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(azure): update flow log compliance text for NSG retirement

3 participants