fix(azure): update flow log compliance text for NSG retirement#10937
Merged
danibarranqueroo merged 2 commits intoApr 29, 2026
Merged
Conversation
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10937 +/- ##
===========================================
+ Coverage 69.01% 86.17% +17.16%
===========================================
Files 104 223 +119
Lines 7596 5744 -1852
===========================================
- Hits 5242 4950 -292
+ Misses 2354 794 -1560
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
7 tasks
pedrooot
approved these changes
Apr 29, 2026
Member
pedrooot
left a comment
There was a problem hiding this comment.
Thanks for this! I love it 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fix #10936
PR #10645 fixed the Azure Network Watcher flow log check behavior and generic check metadata. After that merge, some Azure compliance mappings still contained stale flow-log text for the legacy controls.
The remaining problem is compliance-content specific: several Azure entries still tell users to create or inspect NSG flow logs directly, including old NSG-only portal steps,
az network watcher flow-log configure --nsg ...examples, or NSG-only control wording. That guidance is misleading now that Azure stopped allowing creation of new NSG flow logs after June 30, 2025 and is retiring them on September 30, 2027.This PR keeps the control mappings intact and updates only the Azure compliance text.
Description
network_flow_log_captured_sentmappings so it is retirement-aware and points new or migrated deployments to Virtual network flow logsnetwork_flow_log_more_than_90_daysmappings to remove deprecated--nsgCLI guidance and reflect current flow log migration guidanceprowler_threatscore_azure.jsonso the custom flow-log narrative uses Network Watcher / supported-target wording instead of NSG-only wording and reflects the current retention logicSteps to review
Review the Azure compliance updates in:
prowler/compliance/azure/cis_2.0_azure.jsonprowler/compliance/azure/cis_2.1_azure.jsonprowler/compliance/azure/cis_3.0_azure.jsonprowler/compliance/azure/cis_4.0_azure.jsonprowler/compliance/azure/cis_5.0_azure.jsonprowler/compliance/azure/prowler_threatscore_azure.jsonConfirm the legacy NSG benchmark entries now:
az network watcher flow-log configure --nsg ...Confirm the ThreatScore flow-log entries now:
Network Watcher flow logswording instead ofNetwork Security Group Flow logs0or at least90daysConfirm the SDK changelog entry in
prowler/CHANGELOG.md.Validate JSON syntax:
python3 - <<'PY'
import json, pathlib
for p in sorted(pathlib.Path('prowler/compliance/azure').glob('*.json')):
json.load(open(p))
print('json-ok')
PY
Expected result:
json-ok.Checklist
Community Checklist
SDK/CLI
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.