Skip to content

fix(ui): clean up findings expanded resource row layout#10949

Merged
HugoPBrito merged 2 commits into
masterfrom
PROWLER-1457-finding-header-clarify-scope-labels-and-remove-redundant-logo
May 4, 2026
Merged

fix(ui): clean up findings expanded resource row layout#10949
HugoPBrito merged 2 commits into
masterfrom
PROWLER-1457-finding-header-clarify-scope-labels-and-remove-redundant-logo

Conversation

@HugoPBrito
Copy link
Copy Markdown
Member

@HugoPBrito HugoPBrito commented Apr 30, 2026

Context

PROWLER-1457.

The expanded child rows under a Findings group rendered:

  • A redundant cube icon next to the resource name (already shown on the parent finding row).
  • Service and Region as plain truncated text, while sibling fields (Last seen, Failing for) used a label-above-value style — visually inconsistent.
  • A provider logo with a column titled Account whose alias often duplicated the resource name on container scans, looking like a duplicated block.

Description

In ui/components/findings/table/column-finding-resources.tsx:

  • Remove the leading Container icon from the resource cell.
  • Drop the provider logo from the (now renamed) Provider column.
  • Render Service and Region with <InfoField label="…" variant="compact">, matching the Last seen / Failing for pattern.
  • Reorder columns so the row reads: selector → Fail (Status) → Resource → Provider → Critical (Severity) → Service → Region → Last seen → Failing for → actions.

ui/components/findings/table/inline-resource-container.tsx is updated so the skeleton row matches the new column order.

No backend, type, or data-flow changes — service, region, providerAlias, providerUid were already on FindingResourceRow.

Steps to review

  1. cd ui && pnpm install && pnpm run dev.
  2. Navigate to Findings, expand a finding group with multiple resources.
  3. Confirm on each child row:
    • No cube icon to the left of the resource name.
    • No provider logo in the Provider column (text only).
    • Service / Region rendered with the small grey caption above the value, identical in style to Last seen / Failing for.
    • Column order matches: selector, Fail, Resource, Provider, Critical, Service, Region, Last seen, Failing for, ⋮.
  4. Compare the alias/UID display for AWS/Azure/M365 scans (alias = friendly name like demo) vs container scans (alias = repository path); both work because the data already comes from provider.alias / provider.uid.

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video - Mobile (X < 640px)
  • Screenshots/Video - Tablet (640px > X < 1024px)
  • Screenshots/Video - Desktop (X > 1024px)
  • Ensure new entries are added to ui/CHANGELOG.md

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Remove redundant cube icon next to resource name
- Replace provider logo with text-only Provider column
- Show Service and Region with compact labels matching Last seen and Failing for
- Reorder child columns to Status, Resource, Provider, Severity, then field labels
@HugoPBrito HugoPBrito requested a review from a team as a code owner April 30, 2026 12:11
HugoPBrito added a commit that referenced this pull request Apr 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

✅ All necessary CHANGELOG.md files have been updated.

@HugoPBrito HugoPBrito force-pushed the PROWLER-1457-finding-header-clarify-scope-labels-and-remove-redundant-logo branch from 21528eb to caf0054 Compare April 30, 2026 12:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

🔒 Container Security Scan

Image: prowler-ui:f23a5c4
Last scan: 2026-04-30 12:22:02 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 2
Total 2

2 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@HugoPBrito
Copy link
Copy Markdown
Member Author

image

Copy link
Copy Markdown
Contributor

@alejandrobailo alejandrobailo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HugoPBrito HugoPBrito merged commit 6cb770f into master May 4, 2026
37 checks passed
@HugoPBrito HugoPBrito deleted the PROWLER-1457-finding-header-clarify-scope-labels-and-remove-redundant-logo branch May 4, 2026 10:17
@HugoPBrito HugoPBrito added the backport-to-v5.25 Backport PR to the v5.25 branch label May 4, 2026
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label May 4, 2026
@prowler-bot
Copy link
Copy Markdown
Collaborator

💚 All backports created successfully

Status Branch Result
v5.25

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v5.25 Backport PR to the v5.25 branch component/ui was-backported The PR was successfully backported to the target branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants