Skip to content

fix(aws): do not flag cross-service confused deputy as public #5593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

MrCloudSec
Copy link
Member

Context

Fix #5454.

Description

Do not flag IAM policies with cross service confused deputy as public unless the argument check_cross_service_confused_deputy is passed to the is_policy_public function.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners October 30, 2024 20:00
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (9a7190c) to head (a662eba).
Report is 1159 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5593   +/-   ##
=======================================
  Coverage   89.71%   89.72%           
=======================================
  Files        1101     1102    +1     
  Lines       34192    34215   +23     
=======================================
+ Hits        30674    30698   +24     
+ Misses       3518     3517    -1     
Components Coverage Δ
prowler 89.72% <ø> (+<0.01%) ⬆️
api ∅ <ø> (∅)

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix!!

@jfagoagas jfagoagas merged commit be523c1 into master Nov 4, 2024
11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-5108-review-public-definition-of-resources branch November 4, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"public" definition of resources
2 participants