-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(gcp): add check to detect VMs with multiple network interfaces #9702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(gcp): add check to detect VMs with multiple network interfaces #9702
Conversation
|
✅ All necessary |
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9702 +/- ##
==========================================
+ Coverage 92.70% 92.93% +0.22%
==========================================
Files 129 131 +2
Lines 3153 3197 +44
==========================================
+ Hits 2923 2971 +48
+ Misses 230 226 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
🔒 Container Security ScanImage: 📊 Vulnerability Summary
3 package(s) affected
|
…twork_interfaces check
Context
New security check for GCP Compute Engine to detect VM instances configured with multiple network interfaces. VMs with multiple NICs can act as bridges between networks that should remain isolated, potentially allowing attackers to move laterally between network segments.
Description
This PR adds a new GCP check that verifies whether Compute Engine instances have multiple network interfaces configured. The check evaluates all VM instances and reports:
Note: Instances created by GKE or used as network virtual appliances may legitimately require multiple network interfaces.
Changes include:
Compute Service (
compute_service.py):network_interfacesfield toInstancemodel to store network interface dataNew Check (
compute_instance_multiple_network_interfaces/)Steps to review
network_interfacesfield added to theInstancemodel incompute_service.py(if applicable)_get_instances()compute_instance_multiple_network_interfaces.pymetadata.jsonfor accuracyChecklist
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.