Remove retries and enable setting TCP/IP port #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retries were not limited, making it possible to have a _long_ blocking call, which is not a nice thing in Arduino `loop()`. Limitting would only partially fix the problem. Removing them altogether works much better and user can retry at her own convenience. Support for setting the TCP/IP port was added, which is needed when using a TLS/SSL (network) client class. Before, we always used HTTP port, which would not work.
vveljko
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retries were not limited, making it possible to have a
long blocking call, which is not a nice thing in Arduino
loop(). Limitting would only partially fix the problem.Removing them altogether works much better and user can
retry at her own convenience.
Support for setting the TCP/IP port was added, which is needed
when using a TLS/SSL (network) client class. Before, we always
used HTTP port, which would not work.