Fix CI build #33
Merged
Fix CI build #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't build M4 board at all - it doesn't have native networking, test is not useful, yet it fails on ArduinoCI for some unknown reason. Don't build ESP32 w/WiFi101.h examples, they are not designed to work. It was strange they actually worked before.
davidnub
approved these changes
May 29, 2019
Arduino is a "moving target". Itself changes, board support changes, libraries change... That's why we keep things in comments, as we might need/want to "enable" them in the future, and it's easier to have them in the comments rather than figuring out what can (or cannot) be put back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't build M4 board at all - it doesn't have native networking,
test is not useful, yet it fails on ArduinoCI for some unknown
reason.
Don't build ESP32 w/WiFi101.h examples, they are not designed
to work. It was strange they actually worked before.