Sign Windows release binaries #3455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3455 +/- ##
==========================================
+ Coverage 41.13% 41.15% +0.02%
==========================================
Files 87 87
Lines 12910 12910
==========================================
+ Hits 5310 5313 +3
+ Misses 7205 7203 -2
+ Partials 395 394 -1 ☔ View full report in Codecov by Sentry. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
rquitales
added
the
impact/no-changelog-required
Contributor
Author
|
Note: our prerelease workflow is failing because the current major version is |
t0yv0
approved these changes
Jan 27, 2025
rquitales
added a commit
that referenced
this pull request
Jan 28, 2025
### Added - Windows executable releases are now signed. (<#3455>)
Contributor
|
This PR has been shipped in release v4.21.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds a new Makefile target
make sign-goreleaser-exetarget to sign all built GoReleaser windows binaries. This PR contains 2 changes:Please see the linked ci-mgmt issue for status of GitHub actions workflows to validate that the binaries are signed.