Skip to content

Conversation

@rquitales
Copy link
Contributor

Proposed changes

This resolve a provider panic when valueYamlFiles field in helm.v3.Release resources are nil.

Related issues (optional)

#3600

@rquitales rquitales self-assigned this Apr 15, 2025
Copy link
Contributor

@EronWright EronWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.17%. Comparing base (27f7406) to head (2457872).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3601   +/-   ##
=======================================
  Coverage   41.16%   41.17%           
=======================================
  Files          87       87           
  Lines       12915    12917    +2     
=======================================
+ Hits         5316     5318    +2     
  Misses       7204     7204           
  Partials      395      395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rquitales rquitales enabled auto-merge (squash) April 15, 2025 00:45
@rquitales rquitales force-pushed the rquitales/fix-panic-reflect-check branch from c26f1df to 2457872 Compare April 15, 2025 16:28
@rquitales
Copy link
Contributor Author

CI was previously failing due to: #3602

@rquitales rquitales merged commit fe674f5 into master Apr 15, 2025
19 checks passed
@rquitales rquitales deleted the rquitales/fix-panic-reflect-check branch April 15, 2025 17:03
@rquitales rquitales linked an issue Apr 15, 2025 that may be closed by this pull request
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v4.22.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic in Kuberentes 4.22.1 provider

3 participants