Do not run upgrade check for this provider #202
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
mjeffryes
left a comment
mjeffryes
left a comment
There was a problem hiding this comment.
Seems fine to do this as a quick workaround, but I wonder if we couldn't make the upgrade job resilient to this case?
Makefile
Outdated
| # - Run make ci-mgmt to apply the change locally. | ||
| # | ||
| ci-mgmt: .ci-mgmt.yaml | ||
| find .github/workflows/*.yml -type f ! -name "$(PACK)*.yml" -delete |
There was a problem hiding this comment.
I'm surprised that this changes with the checkUpstreamUpgrade flag change
There was a problem hiding this comment.
This is an unrelated change from bumping ci-mgmt to latest. Since ci-mgmt isn't versioned, each time a change is made to .ci-mgmt.yaml and then applied with make ci-mgmt the latest version of ci-mgmt is pulled.
There was a problem hiding this comment.
It was a recent change in ci-mgmt that had not done the nightly percolation. It's a legitimate change; I verified.
guineveresaenger
force-pushed
the
guin/skip-upstream-upgrade
branch
from
7509f22 to
3e012ee
Compare
guineveresaenger
added
the
impact/no-changelog-required
mikhailshilkov
added
impact/no-changelog-required
|
This PR has been shipped in release v0.3.4. |
5 participants
Because the upstream provider is pre-stable release, we run upgrades manually.
Fixes #200.