Legacy facts present in Chocolatey provider files cause errors on Non-Windows

[chambersmp]

Summary

The operatingsystem fact is disabled by default in Puppet 8.

This leads to an intermittent issue where the provider may be loaded for Unix systems instead of only windows.

See confine and defaultfor:

puppetlabs-chocolatey/lib/puppet/provider/chocolateyconfig/windows.rb

Lines 10 to 11 in c7d75e8

	confine operatingsystem: :windows
	defaultfor operatingsystem: :windows

.

Fix

These should be change to os.name.

Legacy Fact Ref

• https://www.puppet.com/docs/puppet/7/core_facts.html
• https://github.com/puppetlabs/puppet-lint/blob/main/lib/puppet-lint/plugins/legacy_facts/legacy_facts.rb