Fix breaking changes in non-core repos #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit e6f817c introduced a breaking change when downloading the GPG key from non-core repos on SLES. It also incorrectly attempted to manage credentials for non-core repos for all rpm-based platforms. This commit restores the GPG location on yum.puppet.com and guards the sed commands to only run when the repo collection contains "core"
bastelfreak
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/762/files?diff=split&w=1 makes it way more readable.
mhashizume
approved these changes
Mar 3, 2025
mhashizume
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e6f817c introduced a breaking change when downloading the GPG key from non-core repos on SLES.
It also incorrectly attempted to manage credentials for non-core repos for all rpm-based platforms.
This commit restores the GPG location on yum.puppet.com and guards the sed commands to only run when the repo collection contains "core"
This should fix https://jenkins-platform.delivery.puppetlabs.net/view/puppet-agent/view/Acceptance%20Suites/view/CI%20Goalie/job/forge-module_puppetlabs-puppet-agent-module_intn-run_task_acceptance-main/591/