Fix2461 #2486
Fix2461 #2486
Conversation
- Introduced a new function to infer updated coefficients for the Huld model based on EU JRC research. - Added a parameter to the existing Huld function to optionally use these updated coefficients. - Updated documentation to reflect the new functionality and included references to the EU JRC paper. - Added tests to verify the implementation and ensure compatibility with existing functionality. (cherry picked from commit f0ba338)
- Updated the test for the Huld model to use non-reference values for irradiance and temperature. - Enhanced the test to verify that results differ for all supported cell types when using EU JRC coefficients. - Added checks to ensure all cell types are supported and that a KeyError is raised for invalid cell types. (cherry picked from commit 7c0feba)
|
I'm -1 on the new kwarg Comments for my fellow maintainers? |
|
I'm between @cwhanse and @OmarBahamida ; I prefer a |
| .. [2] EU JRC paper, "Updated coefficients for the Huld model", | ||
| https://doi.org/10.1002/pip.3926 |
There was a problem hiding this comment.
Looks like you didn't change this to fit the IEEE citation format nor the :doi: directive (see the citation just above).
I recommend you to read https://pvlib-python.readthedocs.io/en/latest/contributing/style_guide.html
| @@ -69,3 +69,23 @@ def test_huld(): | |||
| with pytest.raises(ValueError, | |||
| match='Either k or cell_type must be specified'): | |||
| res = pvarray.huld(1000, 25, 100) | |||
|
|
|||
|
|
|||
| def test_huld_eu_jrc(): | |||
There was a problem hiding this comment.
Can you check for some specific values, up to 4-5 decimals? It would be better if you calculate them outside of your Python implementation.
I fully support this implementation. It would be a shame to remove existing features. This way we can also have a deprecation cycle, i.e., a period where a warning is raised if the |
|
Any set of coefficients can be provided directly to the existing function, so kwargs like But if we lean towards providing built-in parameters, as a convenience, or as a means to repeat previous analyses (where parameters were not explicit, which is a different problem), then I think the user should be required to affirmatively select them: |
Enhance Huld model with EU JRC coefficients