Skip to content

Fix opening files when targeting android SDK 28 #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Conversation

KleggerKoder
Copy link
Contributor

this fixes issue: #268

@WuglyakBolgoink
Copy link

any updates???

@shnist
Copy link
Collaborator

shnist commented Sep 4, 2019

hi @KleggerKoder, thanks for the pull request! The code you have changed here is 2 years old. If this fixes things when targeting SDK28, is this backwards compatible with older version of the SDK?

@JamesPeck
Copy link

Any Update?

@shnist
Copy link
Collaborator

shnist commented Sep 6, 2019

I'm waiting for @KleggerKoder to get back to me.

@KleggerKoder
Copy link
Contributor Author

@shnist Tested and working on targetSdkVersion 28, 26, 24, 23.
Fails on targetSdkVersion 21 and earlier.

@nip3o
Copy link

nip3o commented Sep 17, 2019

I have this issue and tried installing the plugin from this MR instead of the version in master. I did cordova platform remove android; cordova platform add android after changing the plugin and it seems like the MR version is in the platforms/android/plugins directory, but I get exactly the same error as before. :/

@JamesPeck
Copy link

Any updates on this issue?

@MuseTools
Copy link
Contributor

same error. not work for me

@shnist shnist merged commit 45f5889 into pwlin:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants