Skip to content

Clear LRU caches on pylint utilities#8420

Merged
jacobtylerwalls merged 3 commits intopylint-dev:mainfrom
jacobtylerwalls:lru-caches
Mar 10, 2023
Merged

Clear LRU caches on pylint utilities#8420
jacobtylerwalls merged 3 commits intopylint-dev:mainfrom
jacobtylerwalls:lru-caches

Conversation

@jacobtylerwalls
Copy link
Copy Markdown
Member

Type of Changes

Type
🐛 Bug fix

Description

Closes #8361

Created a new backport label (should I have?)

DanielNoord
DanielNoord previously approved these changes Mar 10, 2023
Copy link
Copy Markdown
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let Pierre say something about the backporting

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2023

Codecov Report

Merging #8420 (f8206be) into main (2b3d113) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8420   +/-   ##
=======================================
  Coverage   95.71%   95.72%           
=======================================
  Files         175      175           
  Lines       18451    18462   +11     
=======================================
+ Hits        17660    17672   +12     
+ Misses        791      790    -1     
Impacted Files Coverage Δ
pylint/checkers/utils.py 96.02% <100.00%> (+0.01%) ⬆️
pylint/lint/run.py 86.56% <100.00%> (+0.20%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for creating the label, when we release we change the one already backported one to "backported" and we could rename to old one or delete the old one / create the new one. I was in the process of doing just that and thought I should upgrade the release.md but then apparently got distracted by a squirrel 😄 I realize now that I did not clean up readthedoc versions either, so this was a fruitful review.

Guard _lru_cache_wrapper under TYPE_CHECKING
@github-actions

This comment has been minimized.

Pierre-Sassoulas added a commit that referenced this pull request Mar 10, 2023
Refs #8420

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Comment thread pylint/checkers/utils.py Outdated
@jacobtylerwalls jacobtylerwalls merged commit ab20812 into pylint-dev:main Mar 10, 2023
@jacobtylerwalls jacobtylerwalls deleted the lru-caches branch March 10, 2023 20:01
github-actions Bot pushed a commit that referenced this pull request Mar 10, 2023
@github-actions
Copy link
Copy Markdown
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit f8206be

Pierre-Sassoulas pushed a commit that referenced this pull request Mar 10, 2023
(cherry picked from commit ab20812)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear pylint's LRU caches when using --clear-cache-post-run

3 participants