-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix UserWarning always being printed #5286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We had the instructions on a wiki page. Can't find it right now either 🤔
Essentially:
pip install pre-commit
# To run it automatically on every commit
pre-commit install
# Or to run it manually
pre-commit run --all
The pre-commit was satisfied with your changes.
The link still has pymc3, the new wiki page uses pymc and directs to the docs. We have to update the new issue template https://github.com/pymc-devs/pymc/wiki/Python-Code-Style |
Codecov Report
@@ Coverage Diff @@
## main #5286 +/- ##
=======================================
Coverage 78.97% 78.97%
=======================================
Files 87 87
Lines 14351 14352 +1
=======================================
+ Hits 11334 11335 +1
Misses 3017 3017
|
...what is going on with coverage? 😅 |
Our count of finished jobs needed before the first coverage estimate is posted is not correct. The codecov comment should update itself as more jobs complete. There is still some noise in the final result though. |
I created a placeholder page for the old name so links continue to work, but we also moved everything to the documentation and shpuld default to that unless there is a compelling reason to use wikis. I updated the wiki but it seems it was renamed right before these changes so the I updated a page where no link was pointing to All those devdoc style pages should use links to latest (instead of stable or specific versions) and will then be automatically updated with every commit |
I noticed that #5268 introduced a small bug that always printed a warning. Now fixed. (@michaelosthege)
I'd be happy to run linting, but the linting/style checks link below from the PR template takes me to a blank page?
Depending on what your PR does, here are a few things you might want to address in the description: