Skip to content

Fix UserWarning always being printed #5286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2021

Conversation

thomasaarholt
Copy link
Contributor

I noticed that #5268 introduced a small bug that always printed a warning. Now fixed. (@michaelosthege)
I'd be happy to run linting, but the linting/style checks link below from the PR template takes me to a blank page?

Depending on what your PR does, here are a few things you might want to address in the description:

Sorry, something went wrong.

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
We had the instructions on a wiki page. Can't find it right now either 🤔
Essentially:

pip install pre-commit

# To run it automatically on every commit
pre-commit install

# Or to run it manually 
pre-commit run --all

The pre-commit was satisfied with your changes.

@ricardoV94
Copy link
Member

ricardoV94 commented Dec 24, 2021

Thanks!
We had the instructions on a wiki page. Can't find it right now either 🤔
Essentially:

pip install pre-commit

# To run it automatically on every commit
pre-commit install

# Or to run it manually 
pre-commit run --all

The pre-commit was satisfied with your changes.

The link still has pymc3, the new wiki page uses pymc and directs to the docs. We have to update the new issue template

https://github.com/pymc-devs/pymc/wiki/Python-Code-Style

@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #5286 (5aa1c0b) into main (aaea02a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5286   +/-   ##
=======================================
  Coverage   78.97%   78.97%           
=======================================
  Files          87       87           
  Lines       14351    14352    +1     
=======================================
+ Hits        11334    11335    +1     
  Misses       3017     3017           
Impacted Files Coverage Δ
pymc/backends/arviz.py 89.16% <100.00%> (+0.04%) ⬆️

@thomasaarholt
Copy link
Contributor Author

...what is going on with coverage? 😅

@michaelosthege
Copy link
Member

...what is going on with coverage? 😅

Our count of finished jobs needed before the first coverage estimate is posted is not correct.
It is set to post a coverage update before all jobs are done. That's because if the count is too high it would never get posted. Not sure, but probably this could be reconfigured to post it exactly when all jobs are done.

The codecov comment should update itself as more jobs complete. There is still some noise in the final result though.

@OriolAbril
Copy link
Member

OriolAbril commented Dec 24, 2021

I created a placeholder page for the old name so links continue to work, but we also moved everything to the documentation and shpuld default to that unless there is a compelling reason to use wikis. I updated the wiki but it seems it was renamed right before these changes so the I updated a page where no link was pointing to

All those devdoc style pages should use links to latest (instead of stable or specific versions) and will then be automatically updated with every commit

@michaelosthege michaelosthege merged commit 2c8f3c3 into pymc-devs:main Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants