Skip to content

Renamed model.recompute_initial_point to model.compute_initial_point #5360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2022

Conversation

Vaibhav-Chopra-GT
Copy link
Contributor

@Vaibhav-Chopra-GT Vaibhav-Chopra-GT commented Jan 16, 2022

Closes #5360

  • what are the (breaking) changes that this PR makes?

Renamed model.recompute_initial_point to model.compute_initial_point throughout the codebase.

@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #5360 (da78a24) into main (38867dd) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5360      +/-   ##
==========================================
- Coverage   80.36%   80.34%   -0.03%     
==========================================
  Files          89       89              
  Lines       14806    14806              
==========================================
- Hits        11899    11896       -3     
- Misses       2907     2910       +3     
Impacted Files Coverage Δ
pymc/backends/base.py 86.56% <50.00%> (ø)
pymc/tests/models.py 87.14% <80.00%> (ø)
pymc/model.py 85.93% <83.33%> (ø)
pymc/bart/pgbart.py 95.23% <100.00%> (ø)
pymc/sampling_jax.py 97.45% <100.00%> (ø)
pymc/smc/smc.py 97.90% <100.00%> (ø)
pymc/step_methods/hmc/base_hmc.py 91.20% <100.00%> (ø)
pymc/step_methods/metropolis.py 83.05% <100.00%> (ø)
pymc/step_methods/mlda.py 96.39% <100.00%> (ø)
pymc/parallel_sampling.py 86.71% <0.00%> (-1.00%) ⬇️

@canyon289
Copy link
Member

Thanks for contribution! Ive approved CI run so you can see the checks

@Vaibhav-Chopra-GT
Copy link
Contributor Author

Thanks @canyon289! Could you please approve them once more? I have fixed the failing tests now!

@canyon289
Copy link
Member

Thank you for the contribution and fixing tests! Can you add a release note as well?

Are you planning on updating the notebooks? No obligation just keeping track of things.

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. We don't need a release notes entry, because the entire method is new in v4.

@twiecki twiecki merged commit c3ffec8 into pymc-devs:main Jan 17, 2022
@twiecki
Copy link
Member

twiecki commented Jan 17, 2022

Thanks @Vaibhav-Chopra-GT!

@Vaibhav-Chopra-GT
Copy link
Contributor Author

Thanks for merging! I do plan on updating the example notebooks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants