-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Renamed model.recompute_initial_point
to model.compute_initial_point
#5360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5360 +/- ##
==========================================
- Coverage 80.36% 80.34% -0.03%
==========================================
Files 89 89
Lines 14806 14806
==========================================
- Hits 11899 11896 -3
- Misses 2907 2910 +3
|
Thanks for contribution! Ive approved CI run so you can see the checks |
Thanks @canyon289! Could you please approve them once more? I have fixed the failing tests now! |
Thank you for the contribution and fixing tests! Can you add a release note as well? Are you planning on updating the notebooks? No obligation just keeping track of things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. We don't need a release notes entry, because the entire method is new in v4
.
Thanks @Vaibhav-Chopra-GT! |
Thanks for merging! I do plan on updating the example notebooks! |
Closes #5360
Renamed
model.recompute_initial_point
tomodel.compute_initial_point
throughout the codebase.