raise not implemented error for non refactored distributions and functions #5799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ferrine MvStudentTRandomWalk and MvGaussianRandomWalk are also not refactored yet |
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #5799 +/- ##
==========================================
- Coverage 89.40% 88.98% -0.42%
==========================================
Files 74 74
Lines 13772 13793 +21
==========================================
- Hits 12313 12274 -39
- Misses 1459 1519 +60
|
ricardoV94
reviewed
May 24, 2022
twiecki
reviewed
May 25, 2022
twiecki
reviewed
May 25, 2022
|
The things left so far as I read are the MvStudentTRandomWalk and MvGaussianRandomWalk |
ricardoV94
force-pushed
the
error-not-refactored-time-series
branch
from
ded8beb to
400e205
Compare
Co-authored-by: Thomas Wiecki <[email protected]>
ricardoV94
force-pushed
the
error-not-refactored-time-series
branch
from
400e205 to
fd31103
Compare
ricardoV94
changed the title
ricardoV94
force-pushed
the
error-not-refactored-time-series
branch
from
d81e9cb to
8962d6f
Compare
michaelosthege
approved these changes
May 31, 2022
twiecki
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5676
NotImplementederror on attempt to create not yet refactored timeseries distributions or sample_posterior_predctive_w