Skip to content

Distributed type hints #6795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

iykat
Copy link
Contributor

@iykat iykat commented Jun 24, 2023

What is this PR about?
This PR is an extension of PR #6635 and aims to add more type hints to the continuous distribution parameters to improve code readability and maintenance
...

Checklist

Major / Breaking Changes

  • ...

New features

  • ...

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • ...

📚 Documentation preview 📚: https://pymc--6795.org.readthedocs.build/en/6795/

@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Merging #6795 (801e0ce) into main (14e673f) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6795   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files          95       95           
  Lines       16185    16185           
=======================================
  Hits        14874    14874           
  Misses       1311     1311           
Impacted Files Coverage Δ
pymc/distributions/continuous.py 97.75% <100.00%> (ø)

@iykat
Copy link
Contributor Author

iykat commented Jun 25, 2023

Hi @ricardoV94, my PR is failing some checks. Can you kindly review and advise?

@ricardoV94
Copy link
Member

Hi @ricardoV94, my PR is failing some checks. Can you kindly review and advise?

You seem to not have installed/run pre-commit: https://github.com/pymc-devs/pymc/actions/runs/5364577123/jobs/9732853644?pr=6795

Check https://www.pymc.io/projects/docs/en/latest/contributing/pr_tutorial.html for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants