fix: deep copy nuts_sampler_kwarg to prevent .pop side effects

[inclinedadarsh]

Description

Deep copy the nuts_sampler_kwargs to prevent the function (.pop method) mutating the original passed dictonary.

Related Issue

• Closes Use of dict.pop in pm.sample leads to side effects #7632

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

---

📚 Documentation preview 📚: https://pymc--7652.org.readthedocs.build/en/7652/

[welcome]

]
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

[ricardoV94]

The kwargs.pop in sample is fine, because it comes from **kwargs, it doesn't need any copy.

The only one that needs is the nuts_sample_kwargs, and only in the nutpie branch before we start popping it.
Just add the nuts_sampler_kwargs = nuts_sampler_kwargs.copy() line here:

pymc/pymc/sampling/mcmc.py

Line 341 in e6c5b1a

compile_kwargs = {}

[inclinedadarsh]

Thank you for correcting me, @ricardoV94; it means a lot to me.
I now understand why we just need the copy in the nutpie branch.

Thank you!

[ricardoV94]

Thanks @inclinedadarsh

Once the tests pass we can merge

[welcome]

]
Congrats on merging your first pull request! 🎉 We here at PyMC are proud of you! 💖 Thank you so much for your contribution 🎁