-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Allow passing graph level attributes to graphviz #7741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
80d49fb
to
78fdd17
Compare
pymc/model_graph.py
Outdated
@@ -439,6 +442,7 @@ def make_graph( | |||
figsize=None, | |||
dpi=300, | |||
node_formatters: NodeTypeFormatterMapping | None = None, | |||
graph_attrs: GraphAttrMapping | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I like the custom type, it makes it seem more complex than it really is. It's not much shorter than dict[str, Any]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no strong feelings about this other than it was to be more consistent with the rest of the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up to you; not a blocker
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7741 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 107 107
Lines 18324 18324
=======================================
Hits 17010 17010
Misses 1314 1314
🚀 New features to boost your workflow:
|
Co-authored-by: Jesse Grabowski <[email protected]>
This add the ability to pass in graph level attributes to the
model_to_graphviz
function. This makes it easier to tweak the layout of the graph.Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7741.org.readthedocs.build/en/7741/