Rewrite useless log1mexp(log1mexp(x))
#474
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathaniel <[email protected]>
Signed-off-by: Nathaniel <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
==========================================
- Coverage 80.66% 80.65% -0.01%
==========================================
Files 160 160
Lines 46025 46030 +5
Branches 11266 11267 +1
==========================================
Hits 37124 37124
- Misses 6668 6672 +4
- Partials 2233 2234 +1
|
ricardoV94
reviewed
Oct 10, 2023
| # Case for log1mexp(log1mexp(x)) -> x | ||
| if isinstance(prev_op, aes_math.Log1mexp) and isinstance(node_op, aes_math.Log1mexp): | ||
| if isinstance(prev_op, aes_math.Log1mexp) and isinstance( |
There was a problem hiding this comment.
This makes more sense as a separate rewrite, analogous to the local_func_inv, something like local_func_inv_nan_switch. Otherwise looks nice. Would also need a test
ricardoV94
changed the title
log1mexp(log1mexp(x))
Signed-off-by: Nathaniel <[email protected]>
|
Not entirely sure why this would fail @ricardoV94 , i haven't touched any code on the failing test: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471
Small rewrite changes to allow pytensor to cancel iterative applications of the log1mexp() function
The lack of rewrite caused issues in the application of pm.Censored on the Weibull distribution: pymc-devs/pymc-examples#580
...
I've added a new case to the existing math re-write functions as discussed with @ricardoV94
...
Checklist
Major / Breaking Changes
NA
New features
NA
Bugfixes
NA
Documentation
NA
Maintenance
NA