Skip to content

Conversation

@hoodmane
Copy link
Member

We haven't wanted this for a long time

We haven't wanted this for a long time
@ryanking13 ryanking13 added the integration This PR will run the integration tests. This label can be used as a persistent marker to do so. label Dec 11, 2025
Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enabled integration test.

Don't we need to update the default rust toolchain version too to make this work?

Also, we tested this in #42 but somehow the downstream PR is closed. Do you remember what kind of error we faced at that time?

@hoodmane
Copy link
Member Author

We're overriding this in Makefile.envs:
https://github.com/pyodide/pyodide/blob/main/Makefile.envs#L15

@ryanking13
Copy link
Member

We're overriding this in Makefile.envs:
https://github.com/pyodide/pyodide/blob/main/Makefile.envs#L15

Yes, but the config in pyproject.toml dominates the one in the Makefile.envs. So we can test set custom rustflags overwriting the default one.

@hoodmane
Copy link
Member Author

We clearly don't want this as a default. Presumably we can add it explicitly to any recipe that needs it?

@hoodmane
Copy link
Member Author

Anyways I'd like to switch to stable Rust in the next few months and to do that we need to stop passing unstable flags.

@ryanking13
Copy link
Member

We clearly don't want this as a default. Presumably we can add it explicitly to any recipe that needs it?

Sounds reasonable.

@hoodmane hoodmane merged commit 8a42492 into pyodide:main Dec 16, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration This PR will run the integration tests. This label can be used as a persistent marker to do so.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants