Validate msgid_plural
against msgstr[0]
for languages with nplurals=1
#1198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python format checker currently only validates
msgid
against the translation for languages with only one plural form.msgid_plural
is not checked. For example, this:does not get flagged even though it should (missing
%s
in the translation).Here's a real-world example:
This translation should get flagged if it was missing the
%(count)s
placeholder since it appears inmsgid_plural
. it's not the case because onlymsgid
is checked currently.(This translation actually produces warnings as is, because the singular does not contain
%(count)s
, so perhaps an even better solution would be to only validate against the plural, but I'm not so sure about that)