chore: bump minimum Poetry/poetry-core version and drop compat code #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radoering
requested changes
Oct 11, 2022
Member
radoering
left a comment
radoering
left a comment
There was a problem hiding this comment.
We have to remove the unused "type ignore". Further, one of the canonicalize_name in command.py can be removed because package.extras is always normalized now.
|
Kudos, SonarCloud Quality Gate passed!
|
Member
Author
|
Good catch, I've pushed the two changes. |
radoering
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that 1.2.2 is out we can bump the minimum version requirement for this plugin.
This should unblock #104.