Skip to content

Conversation

@b-kamphorst
Copy link
Contributor

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the imports forward compatible please? The scheme is try "new import" except "old import". Proposals below. You probably have to add some "type: ignore" or similar to satisfy mypy and flake8.

@b-kamphorst
Copy link
Contributor Author

Can you make the imports forward compatible please? The scheme is try "new import" except "old import". Proposals below. You probably have to add some "type: ignore" or similar to satisfy mypy and flake8.

Indeed, the current PR is valid only for "poetry = ^1.3.0" so that it is valid only after poetry 1.3.0 is released. I have made it backwards compatible in the way you describe so that we can release it already. If this PR is released only after the release of poetry 1.3.0, you may consider dropping the last commit (and require poetry = ^1.3.0).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@b-kamphorst b-kamphorst marked this pull request as ready for review November 1, 2022 01:18
@radoering
Copy link
Member

Yeah, if poetry-plugin-export and poetry would not be so closely coupled we could just wait. Unfortunately, we are still delivering poetry-plugin-export with poetry. (We intend to stop doing this. Another maintainer has already created a proof-of-concept on how to proceed in a gracefully way but he hasn't been available lately.) That's why we want to release a version of poetry-plugin-export that can be delivered with poetry 1.3 and will not trigger a deprecation warning.

@radoering radoering merged commit 3f27c6b into python-poetry:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants