-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Documentation: Clarified negating VCS excluded files #10442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideRefines the File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Deploy preview for website ready! ✅ Preview Built with commit c3461d8. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
My earlier issue (#10418) was caused a misleading statement in the documentation which conflicts with a later statement:
As written, this is untrue because of the asymmetry between
includeandexclude:So only declaring
includeentries with explicit formats can properly negate VCS.To try to help future readers, I've moved the discussion of VCS down below the part on explicit formats so the closest code examples show explicit format, and clarified the note to inform readers the format must also be given.
Pull Request Check List
Resolves: #10418
Summary by Sourcery
Documentation:
formatmust be provided when usingincludeto override VCS ignore settings.