-
Notifications
You must be signed in to change notification settings - Fork 2.4k
improve pyproject.toml validation error messages by replacing data with tool.poetry
#10471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve pyproject.toml validation error messages by replacing data with tool.poetry
#10471
Conversation
Reviewer's GuideThis PR updates the validation logic to prefix error paths with 'tool.poetry.' instead of 'data.' and adjusts existing tests to expect the new message format. Class diagram for updated validation error message handlingclassDiagram
class Factory {
+validate(toml_data, strict)
}
Factory : validate() now replaces 'data.' with 'tool.poetry.' in error messages
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Aearsears - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
data with tool.poetry
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #9900
Replaces the
dataprefix in the validation error messages withtool.poetryto better report toml structure errorsSummary by Sourcery
Replace 'data.' prefix in pyproject.toml validation error messages with 'tool.poetry.' and adjust tests accordingly
Enhancements:
Tests:
Summary by Sourcery
Replace the "data." prefix in pyproject.toml validation error messages with "tool.poetry." and adjust tests accordingly
Enhancements:
Tests: