Skip to content

Conversation

@radoering
Copy link
Member

@radoering radoering commented Aug 19, 2025

Summary by Sourcery

Relax findpython dependency to include version 0.7 and update tests to satisfy its new interface

Enhancements:

  • Relax findpython upper version bound in pyproject.toml to <0.8.0

Tests:

  • Add freethreaded property to MockPythonVersion in tests for compatibility with findpython 0.7

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 19, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR relaxes the findpython dependency upper bound to allow 0.7.x releases by updating the version constraint and regenerating the lockfile, and extends the MockPythonVersion test stub with a new freethreaded property.

Class diagram for updated MockPythonVersion test stub

classDiagram
    class MockPythonVersion {
        +major: int
        +minor: int
        +micro: int
        +releaselevel: str
        +serial: int
        +arch: str
        +implementation: str
        +path: str
        +executable: str
        +version: str
        +freethreaded: bool
    }
Loading

File-Level Changes

Change Details Files
Relax findpython dependency upper bound to include 0.7.x
  • Updated findpython constraint from <0.7.0 to <0.8.0 in pyproject.toml
  • Regenerated poetry.lock to reflect the updated dependency
pyproject.toml
poetry.lock
Introduce freethreaded property in MockPythonVersion
  • Added a @Property freethreaded method returning False to the test mock
tests/conftest.py

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Please regenerate poetry.lock after updating pyproject.toml so that the lock file matches the new findpython constraint.
  • Since freethreaded is only introduced in findpython 0.7, add a fallback or guard in the production code to avoid attribute errors when using findpython 0.6.x.
  • Consider adding tests that cover both True and False values of the new freethreaded property to validate behavior for different interpreter threading models.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Please regenerate poetry.lock after updating pyproject.toml so that the lock file matches the new findpython constraint.
- Since freethreaded is only introduced in findpython 0.7, add a fallback or guard in the production code to avoid attribute errors when using findpython 0.6.x.
- Consider adding tests that cover both True and False values of the new freethreaded property to validate behavior for different interpreter threading models.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering merged commit 1c059ea into python-poetry:main Aug 19, 2025
53 checks passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2025
@radoering radoering deleted the update-findpython branch December 13, 2025 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant