-
Notifications
You must be signed in to change notification settings - Fork 2.4k
deps: allow findpython 0.7 #10510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: allow findpython 0.7 #10510
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR relaxes the findpython dependency upper bound to allow 0.7.x releases by updating the version constraint and regenerating the lockfile, and extends the MockPythonVersion test stub with a new freethreaded property. Class diagram for updated MockPythonVersion test stubclassDiagram
class MockPythonVersion {
+major: int
+minor: int
+micro: int
+releaselevel: str
+serial: int
+arch: str
+implementation: str
+path: str
+executable: str
+version: str
+freethreaded: bool
}
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Please regenerate poetry.lock after updating pyproject.toml so that the lock file matches the new findpython constraint.
- Since freethreaded is only introduced in findpython 0.7, add a fallback or guard in the production code to avoid attribute errors when using findpython 0.6.x.
- Consider adding tests that cover both True and False values of the new freethreaded property to validate behavior for different interpreter threading models.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Please regenerate poetry.lock after updating pyproject.toml so that the lock file matches the new findpython constraint.
- Since freethreaded is only introduced in findpython 0.7, add a fallback or guard in the production code to avoid attribute errors when using findpython 0.6.x.
- Consider adding tests that cover both True and False values of the new freethreaded property to validate behavior for different interpreter threading models.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary by Sourcery
Relax findpython dependency to include version 0.7 and update tests to satisfy its new interface
Enhancements:
Tests: