prefer stdlib TemporaryDirectory

[dimbleby]

dropping python 3.7 per #7674 moves poetry past the Windows python 3.7 bugs that made the homegrown temporary_directory() worthwhile

Summary by Sourcery

Enhancements:

• Use stdlib TemporaryDirectory with ignore_cleanup_errors=True across metadata inspection, installation, HTTP download, and ephemeral environment creation paths.

[eamanu]

LGTM, we just need to wait for 3.7 drop :-)

[dimbleby]

LGTM, we just need to wait for 3.7 drop :-)

In fact python-poetry/poetry-core#460 seems to leave poetry committed to its own implementation until support for python 3.9 (or windows!) can be dropped

[eamanu]

@dimbleby try to avoid force push

[dimbleby]

@eamanu thanks but no thanks.

per my last comment this is unlikely to be merged for quite some time and it is absolutely more sensible that when that time comes it will be best represented as a single commit on top of main.

All due respect but you have now made two low-value comments on this MR, please stop.

[dimbleby]

with support for python 3.9 now dropped, ignore_cleanup_errors is always available in the standard library TemporaryDirectory - so homegrown workarounds are no longer needed

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replace usages of a custom temporary_directory context manager and default tempfile.TemporaryDirectory with the standard library’s TemporaryDirectory while enabling ignore_cleanup_errors to avoid cleanup failures, now that Python 3.7 compatibility is dropped.

File-Level Changes

Change	Details	Files
Replace custom temporary directory helper with stdlib TemporaryDirectory using ignore_cleanup_errors where temporary workspaces are created.	Swap temporary_directory() usages for TemporaryDirectory(ignore_cleanup_errors=True) in sdist inspection, installation, HTTP download caching, and ephemeral environment creation paths. Ensure all temporary directories created for extraction, download, and virtualenv setup tolerate cleanup errors during context manager exit.	src/poetry/inspection/info.py src/poetry/installation/chef.py src/poetry/repositories/http_repository.py src/poetry/utils/env/__init__.py
Align existing tempfile.TemporaryDirectory usage with new ignore_cleanup_errors behavior.	Update get_pep517_metadata to pass ignore_cleanup_errors=True to tempfile.TemporaryDirectory for consistent cleanup behavior with other temporary directory usages.	src/poetry/inspection/info.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The switch between TemporaryDirectory(...) and tempfile.TemporaryDirectory(...) is inconsistent across files; consider standardizing on one import style to keep usage uniform.
• Since ignore_cleanup_errors=True is now repeated at each call site, consider wrapping TemporaryDirectory in a small local helper/contextmanager so the Windows-specific behavior is centralized and easier to adjust later.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The switch between `TemporaryDirectory(...)` and `tempfile.TemporaryDirectory(...)` is inconsistent across files; consider standardizing on one import style to keep usage uniform.
- Since `ignore_cleanup_errors=True` is now repeated at each call site, consider wrapping `TemporaryDirectory` in a small local helper/contextmanager so the Windows-specific behavior is centralized and easier to adjust later.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}