Skip to content

Conversation

@finswimmer
Copy link
Member

experimental.system-git-client was introduced in 1.2.0. Let's stop calling it "experimental".

@finswimmer finswimmer marked this pull request as ready for review October 21, 2024 04:55
@finswimmer finswimmer requested a review from a team October 21, 2024 04:55
@finswimmer finswimmer added this to the Poetry 2.0 milestone Oct 21, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could add some feature to config to make the transition easier for users. Right now, if someone has the "old" version of the option, they would have to manually set the new option too. Any ideas?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it as well. Because I couldn't come up immediately with a solution, I decided to say: It's a major version bump with breaking changes and users have to check there config for necessary changes.

If we have strong feelings about the user experience here, I have to think about it more deeply.

@finswimmer finswimmer added the impact/changelog Requires a changelog entry label Oct 25, 2024
@finswimmer finswimmer merged commit 521d441 into python-poetry:main Oct 25, 2024
Secrus pushed a commit to Secrus/poetry that referenced this pull request Oct 27, 2024
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

impact/changelog Requires a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants