Skip to content

Conversation

@radoering
Copy link
Member

Pull Request Check List

Resolves: #9885

  • Added tests for changed code.
  • Updated documentation for changed code.

I think we should do a 1.8 release, which requires pkginfo >= 1.12 to reduce support workload.

Further, after some testing I agree to @Secrus' proposal to loosen the check for unknown METADATA versions.

We introduced this check because pkginfo < 1.11.0 did not handle unknown versions well:

>>> print(pkginfo.Wheel("demo_metadata_version_299-0.1.0-py2.py3-none-any.whl").requires_dist)
()

However, pkginfo >= 1.11.0 handles it better:

>>> print(pkginfo.Wheel("demo_metadata_version_299-0.1.0-py2.py3-none-any.whl").requires_dist)
['cleo; extra == "foo"', 'pendulum (>=1.4.4)', 'tomlkit; extra == "bar"']
NewMetadataVersion: New metadata version (2.99) higher than latest supported version: parsing as 2.3

@radoering radoering added the backport/1.8 Backport a PR to 1.8 through an automated PR label Dec 6, 2024
@radoering radoering changed the title info: require pkginfo >= 1.12 for METADATA 2.4 support and loosen check for unknown METADATA versions info: require pkginfo >= 1.12 for METADATA 2.4 support and loosen check for unknown METADATA versions Dec 6, 2024
@radoering radoering requested a review from a team December 6, 2024 05:30
Copy link
Member

@Secrus Secrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for tackling this issue.

@radoering radoering merged commit a3cae0c into python-poetry:main Dec 6, 2024
73 checks passed
@poetry-bot
Copy link

poetry-bot bot commented Dec 6, 2024

The backport to 1.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8 1.8
# Navigate to the new working tree
cd .worktrees/backport-1.8
# Create a new branch
git switch --create backport-9888-to-1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a3cae0cb2676bc6408f7205f167fbf4abf72d0be
# Push it to GitHub
git push --set-upstream origin backport-9888-to-1.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8

Then, create a pull request where the base branch is 1.8 and the compare/head branch is backport-9888-to-1.8.

radoering added a commit to radoering/poetry that referenced this pull request Dec 6, 2024
…heck for unknown METADATA versions (python-poetry#9888)

(cherry picked from commit a3cae0c)
radoering added a commit that referenced this pull request Dec 6, 2024
…heck for unknown METADATA versions (#9888)

(cherry picked from commit a3cae0c)
sebhmg added a commit to MiraGeoscience/conda-lock that referenced this pull request Dec 13, 2024
@github-actions
Copy link

github-actions bot commented Jan 6, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2025
@radoering radoering deleted the metadata-24 branch December 13, 2025 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/1.8 Backport a PR to 1.8 through an automated PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

poetry 1.8.3 fails to install python wheel package with metadata 2.4

2 participants