The Flask/Blueprint API moved to the Scaffold base class

[jloehel]

Changed in: pallets/flask@b146a13

Fixes: #308

Signed-off-by: Jürgen Löhel [email protected]

[codecov]

Codecov Report

Merging #309 (0dbcd4b) into master (1352aab) will decrease coverage by 0.63%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
- Coverage   96.88%   96.24%   -0.64%     
==========================================
  Files          20       20              
  Lines        2727     2689      -38     
==========================================
- Hits         2642     2588      -54     
- Misses         85      101      +16     

Impacted Files	Coverage Δ
flask_restx/api.py	96.19% <50.00%> (-0.52%)	⬇️
flask_restx/schemas/__init__.py	80.00% <0.00%> (-3.61%)	⬇️
flask_restx/cors.py	78.04% <0.00%> (-2.44%)	⬇️
flask_restx/model.py	95.34% <0.00%> (-1.69%)	⬇️
flask_restx/swagger.py	95.48% <0.00%> (-1.26%)	⬇️
flask_restx/marshalling.py	97.27% <0.00%> (-0.95%)	⬇️
flask_restx/reqparse.py	97.85% <0.00%> (-0.87%)	⬇️
flask_restx/fields.py	96.39% <0.00%> (-0.25%)	⬇️
flask_restx/namespace.py	94.47% <0.00%> (-0.07%)	⬇️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1352aab...0dbcd4b. Read the comment docs.

[j5awry]

Approved. waiting on passing tests.

[j5awry]

Hm...this errors need looked into. At the same time, I don't think they're specifically related to this PR. I'll have to dig in a little bit and see what's happening here...

[andreykurilin]

@j5awry hi!
The issue relates to the recently released werkzeug that contains pallets/werkzeug#1758 . Instead of calling inner helper method that handled None description, werkzeug switched to use html.escape.

There is also new related issue - pallets/werkzeug#2115

[j5awry]

@andreykurilin Thanks! I was just getting up to check on all this, and hit re-run to see if it was ephemeral.

I'm leaning towards setting flask-restx to

flask >=0.8, <2.0.0
werkzeug <2.0.0

at least until those stabilize a bit.

[ziirish]

@j5awry I'd do the same as well.
We have a pending work on dropping support for python <=3.5 we could finish this and work on integrating Flask >=2.0 in a future release.

[j5awry]

related PR is up to pin versions:

#311

Once tests pass there, confirming issues here are dependency related, i'll pull this in as well, then cut a release.