-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
Closed
Labels
3.9only security fixesonly security fixestestsTests in the Lib/test dirTests in the Lib/test dirtopic-IDLEtopic-tkintertype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
BPO | 27196 |
---|---|
Nosy | @terryjreedy, @ned-deily, @serhiy-storchaka |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/terryjreedy'
closed_at = None
created_at = <Date 2016-06-03.08:00:06.971>
labels = ['expert-IDLE', 'type-bug', 'expert-tkinter', '3.9']
title = "Eliminate 'ThemeChanged' warning when running IDLE tests"
updated_at = <Date 2020-01-07.22:42:55.465>
user = 'https://github.com/terryjreedy'
bugs.python.org fields:
activity = <Date 2020-01-07.22:42:55.465>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = False
closed_date = None
closer = None
components = ['IDLE', 'Tkinter']
creation = <Date 2016-06-03.08:00:06.971>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 27196
keywords = []
message_count = 7.0
messages = ['267078', '267081', '267226', '267228', '268861', '269089', '359559']
nosy_count = 4.0
nosy_names = ['terry.reedy', 'ned.deily', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue27196'
versions = ['Python 3.9']
Linked PRs
- GH-71383: IDLE - Document testing subsets of modules #104463
- [3.11] GH-71383: IDLE - Document testing subsets of modules (GH-104463) #104464
- gh-71383: add upstream fix to macOS installer #108806
- gh-71383: Update Tcl/Tk version in Windows to our patched build containing a targeted upstream fix #112973
Metadata
Metadata
Assignees
Labels
3.9only security fixesonly security fixestestsTests in the Lib/test dirTests in the Lib/test dirtopic-IDLEtopic-tkintertype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Projects
Status
Done
Milestone
Relationships
Development
Select code repository
Activity
terryjreedy commentedon Jun 3, 2016
When running "python_d.exe -m test_idle from console or when running test file from IDLE after starting it in either console or by import, the following sometimes appears.
can't invoke "event" command: application has been destroyed
while executing
"event generate $w <<ThemeChanged>>"
(procedure "ttk::ThemeChanged" line 6)
invoked from within
"ttk::ThemeChanged"
Serhiy, this is pobably not critical, but it is annoying. Perhaps the 'kill-callbacks' patch would fix this. Still, I try to have IDLE tests cleanup properly.
Known repeatable occurrences:
serhiy-storchaka commentedon Jun 3, 2016
This looks as a duplicate of bpo-20567.
python-dev commentedon Jun 4, 2016
New changeset 0207c6203f84 by Terry Jan Reedy in branch '3.5':
Issue bpo-27196: Stop 'application destroyed' warnings when running IDLE tests.
https://hg.python.org/cpython/rev/0207c6203f84
New changeset 2d864ac472f0 by Terry Jan Reedy in branch 'default':
Merge issue bpo-27196 from 3.5: Stop IDLE test 'application destroyed' warnings.
https://hg.python.org/cpython/rev/2d864ac472f0
terryjreedy commentedon Jun 4, 2016
I closed bpo-20567 after finishing what I intended to do 3 years ago. I decided make this a separate issue for trying Serhiy's suggestion of updata_idletasks. Pursuing 'no default root' is bpo-24137.
3 other files also gave the warning, once, when run alone. 2 of the 4 'warned with the test suite in 3.5 and 3 of 4 in 3.6. Adding root.update or root.update_idletasks to all 4 fixed all warnings I know of for both versions. It appears to be a coincidence that the warnings consistently appeared where they did. I also added a note about this fix to README.txt.
There is no known problem in 2.7. I fixed 3.5 also because the warnings sometimes appear in buildbot reports, and they don't need the noise.
ned-deily commentedon Jun 19, 2016
FWIW, I'm still seeing these errors on OS X (10.11.5 with ActiveTcl 8.5.18) using 2.7.12rc1, 3.5.2rc1, and top-of-trunk 3.6.0. They do not occur on the same platform when using 2.7.11 or 3.5.1.
For example:
$ /usr/local/bin/python2.7
Python 2.7.12rc1 (v2.7.12rc1:13912cd1e7e8, Jun 11 2016, 15:32:34)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin [...]
$ /usr/local/bin/python2.7 -m test.regrtest -ugui -j3 test_idle
can't invoke "event" command: application has been destroyed
while executing
"event generate $w <<ThemeChanged>>"
(procedure "ttk::ThemeChanged" line 6)
invoked from within
"ttk::ThemeChanged"
can't invoke "event" command: application has been destroyed
while executing
"event generate $w <<ThemeChanged>>"
(procedure "ttk::ThemeChanged" line 6)
invoked from within
"ttk::ThemeChanged"
[1/1] test_idle
1 test OK.
terryjreedy commentedon Jun 22, 2016
The only thing I still see is a pair of ThemeChanged warnings from 2.7. Using binary search, I identified test_editmenu as the culprit. This in spite of all the cleanup I can think of
When I tried to determine which test method(s) gave the warning, as disable all to make sure the warnings vanished, which then did. But after re-enabling, the warnings did not come back -- until they did after a few more runs. I suspect that the only permanent solution will be Serhiy's patch to have .destroy cancel pending callbacks.
terryjreedy commentedon Jan 7, 2020
2.7 EOL.
Ned, do you still see Themed Changed? I don't on 3.8 on Macbook. with 10.14 mohave(?)
30 remaining items
[3.12] gh-110950: add upstream Tk fixes to macOS installer. (GH-111041)…
ned-deily commentedon Nov 21, 2023
Thanks for the PRs. The fix for Tk in the macOS installer has now been merged for release in 3.13.0a2, 3.12.1, and 3.11.7.
pythongh-71383: Update Tcl/Tk version in Windows to our patched build…
pythongh-71383: Update Tcl/Tk in Windows installer to 8.6.13.1
gh-71383: Update Tcl/Tk version in Windows to our patched build conta…
zooba commentedon Dec 11, 2023
Windows fix is now committed for 3.13. As discussed elsewhere, I'm not comfortable backporting the patched build to 3.12 or earlier without someone present to promptly debug and fix any issues that arise.
terryjreedy commentedon Dec 12, 2023
Unless Serhiy wants to do the Windows backports, I am happy to have this closed. I currently cannot repeat the problems on 3.11/12 Windows I reported last May in #71383 (comment). (This is not the first time the messages have appeared and disappeared.) And the patch should prevent any future appearances. If something reappears in 3.12, I now know not to waste more time trying to make it go away. If something reappears in main after this patch, it should be a new issue.
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
pythongh-71383: Update Tcl/Tk version in Windows to our patched build…
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
pythongh-71383: Update Tcl/Tk version in Windows to our patched build…