Skip to content

Test --enable-pystats in CI #99873

Open
Open
@mdboom

Description

@mdboom
Contributor

Feature or enhancement

Run the tests on an --enable-pystats build as part of CI and/or buildbots.

Pitch

In #99701, it was discovered that the --enable-pystats build was broken by an unrelated change. No harm in that -- it's the usual unexpected interaction that happens all the time.

But if we want --enable-pystats to continue to work, we probably need to have some CI for it.

I don't feel super strongly about this -- every new bit of CI has a non-zero maintenance cost, and in this case there is a really small audience for collecting these sorts of stats (mainly those working on the specializing interpreter).

However, if there is enough interest, I did want to suggest it and offer my time to put it together.

Activity

added
type-featureA feature request or enhancement
testsTests in the Lib/test dir
on Nov 29, 2022
corona10

corona10 commented on Dec 11, 2022

@corona10
Member

Hi @mdboom cc @ericsnowcurrently @vstinner
I think that we need to add this feature for a specific purpose.
I am thinking about the following pipeline and I am going to work on if you don't mind I would like to assign the issue to myself.

Step 1: If the PR author adds the label bytecode-stats then execute step 2, if not stop at this stage.
Step 2: GitHub Action will be executed and the CPython will be built with --enable-pystats.
Step 3: Install pyperformance
Step 4: Run pyperformnace
Step 5: Collect bytecode execution stats.
Step 6: Send a comment to the bytecode execution stat through the PR comment.

By the suggested pipeline, the PR reviewer will be easier to analyze the effects of PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dirtype-featureA feature request or enhancement

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @mdboom@corona10

        Issue actions

          Test `--enable-pystats` in CI · Issue #99873 · python/cpython