Skip to content

[3.9] bpo-29620: iterate over a copy of sys.modules (GH-4800) #29605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 18, 2021

unittest.TestCase.assertWarns no longer raises a RuntimeException
when accessing a module's __warningregistry__ causes importation of a new
module, or when a new module is imported in another thread.

Patch by Kernc.
(cherry picked from commit 46398fb)

Co-authored-by: kernc [email protected]

https://bugs.python.org/issue29620

unittest.TestCase.assertWarns no longer raises a RuntimeException
when accessing a module's ``__warningregistry__`` causes importation of a new
module, or when a new module is imported in another thread.

Patch by Kernc.
(cherry picked from commit 46398fb)

Co-authored-by: kernc <[email protected]>
@sweeneyde
Copy link
Member

sweeneyde commented Nov 18, 2021

It seems this change missed 3.9 when it was merged. See also https://bugs.python.org/issue45836

@miss-islington
Copy link
Contributor Author

@kernc and @akuchling: Status check is done, and it's a success ✅ .

@ambv ambv merged commit 71d842b into python:3.9 Nov 18, 2021
@miss-islington miss-islington deleted the backport-46398fb-3.9 branch November 18, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants