Skip to content

Followup tasks for checkmember.py refactoring #19299

@ilevkivskyi

Description

@ilevkivskyi
Member

These are some of the remaining tasks after #7724 is done. These are either somewhat tricky and/or somewhat boring and/or less pressing. In no particular order:

  • We should cleanup/unify attribute writeability logic when checking overrides and subtyping. Most notably:
    • Multiple inheritance is quite messy in this regard.
    • Descriptors with custom __set__() should follow the same logic (including use of mutable-override error code) as properties with custom setters in protocol subtyping and LSP checks.
  • We need to set type_checker in more places to benefit from the new (complete) logic for find_member(), most notable in semanal_typeargs.py and in post-semanal plugins.
  • Now that all attribute access is going through checkmember we should refactor it itself. Couple ideas:
    • Merge bind_self() and check_self_arg()
    • Generalize/extend analyze_decorator_or_funcbase_access()
    • Cleanup class attribute access and unify it with instance attribute access
  • We should re-think how deferrals work, and re-enable some deferrals that are currently skipped (current logic is too limited, we stop all inference after first deferral, and can't defer module scope). The new logic may be like this:
    • We can defer either a module scope or a top-level function (similar to fine-grained incremental)
    • Use "sticky" (i.e. propagating to nested nodes) flag to suppress Any-related error reporting
    • Use new TypeOfAny to suppress inferring bogus Any types for variables
    • Update all isinstance()-like checks to handle this new kind of Any
  • Cleanup Var (and related RefExpr and AssignmentStmt) flags. There are way too many of them, and some of them are used inconsistently.
  • Couple pedantic things we shouldn't even do:
    • Check class level access for descriptor overrides
    • Take into account __getattr__() for LSP checks

Activity

self-assigned this
on Jun 14, 2025
ilevkivskyi

ilevkivskyi commented on Jun 14, 2025

@ilevkivskyi
MemberAuthor

cc @JukkaL just FYI so that you are more aware of the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @ilevkivskyi

      Issue actions

        Followup tasks for checkmember.py refactoring · Issue #19299 · python/mypy