Skip to content

[mypyc] Support yields while values are live #16305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 22, 2025
Merged

[mypyc] Support yields while values are live #16305

merged 15 commits into from
Apr 22, 2025

Conversation

msullivan
Copy link
Collaborator

@msullivan msullivan commented Oct 21, 2023

Also support await while temporary values are live.

@msullivan msullivan changed the title Support yields while values are live [mypyc] Support yields while values are live Oct 21, 2023
mypyc/ir/ops.py Outdated
@@ -235,6 +235,10 @@ def can_raise(self) -> bool:
def sources(self) -> list[Value]:
"""All the values the op may read."""

@abstractmethod
def set_sources(self, new: list[Value]) -> None:
"""Rewrite the soruces of an op"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: soruces

@JukkaL
Copy link
Collaborator

JukkaL commented Jan 15, 2025

@msullivan FYI, we are planning to complete this PR within the next month or so.

@JukkaL JukkaL marked this pull request as ready for review April 16, 2025 15:18
@JukkaL JukkaL merged commit c274971 into master Apr 22, 2025
12 checks passed
@JukkaL JukkaL deleted the yield-spillage branch April 22, 2025 09:20
@msullivan
Copy link
Collaborator Author

Fixes mypyc/mypyc#693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants