Skip to content

Allow variables inside isinstance #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JukkaL merged 3 commits into from
Apr 3, 2017
Merged

Allow variables inside isinstance #3070

JukkaL merged 3 commits into from
Apr 3, 2017

Conversation

@pkch
Copy link
Contributor

@pkch pkch commented Mar 28, 2017

Fixes #3068

This would allow the use of variables inside the second argument to isinstance/issubclass, as long as those variables are assigned a tuple of types in a "visible range".

@pkch pkch force-pushed the fix-isinstance-tuple branch from 46520b0 to 6e85c32 Compare March 28, 2017 08:24
@elazarg
Copy link
Contributor

elazarg commented Mar 28, 2017

Looks like an elegant fix.
Perhaps you can remove the TODOs in binder.py (L113 and L206) along the way, and as additional test.

@pkch pkch force-pushed the fix-isinstance-tuple branch from bec22c3 to 0f06e06 Compare March 28, 2017 19:23
@pkch pkch mentioned this pull request Mar 28, 2017
Open
@JukkaL
Copy link
Collaborator

JukkaL commented Apr 3, 2017

Thanks for the fix!

@JukkaL JukkaL merged commit 62d4bc8 into python:master Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkch @elazarg @JukkaL