Add _file in class SpooledTemporaryFile in tempfile.pyi #10327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Akuli
reviewed
Jun 20, 2023
Collaborator
Akuli
left a comment
Akuli
left a comment
There was a problem hiding this comment.
This was trickier than I thought, but I figured it out :)
Co-authored-by: Akuli <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Akuli
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Dr-Irv This is a draft PR that attempts to close #10286
I have _file attribute in class SpooledTemporaryFile using hints given by @Akuli in #10286
So, please provide feedback and let me know if there are any changes to make.
On further looking into documentation I found that there can also be a true file object that needs to be returned depending on whether rollover() has been called
I can add it later once I get feedback or might make another PR if required.
P.S. I ran the tests before making a PR and it was all good. But they are failing here for some reason.