Skip to content

pyright: Don't report incompatible overrides #7498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2022
Merged

pyright: Don't report incompatible overrides #7498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pyrightconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
"reportUntypedNamedTuple": "error",
"reportPrivateUsage": "none",
"reportConstantRedefinition": "error",
"reportIncompatibleMethodOverride": "error",
"reportIncompatibleVariableOverride": "error",
"reportInvalidStringEscapeSequence": "error",
"reportUnknownArgumentType": "error",
"reportUnknownLambdaType": "error",
Expand All @@ -44,6 +42,10 @@
"reportPropertyTypeMismatch": "error",
"reportSelfClsParameterName": "error",
"reportUnsupportedDunderAll": "error",
// Incompatible overrides are out of typeshed's control as they are
// inherited from the implementation.
"reportIncompatibleMethodOverride": "none",
"reportIncompatibleVariableOverride": "none",
// Overlapping overloads cannot be enabled at this time because
// of the "fractions.Fraction.__pow__" method and "tasks.gather" function.
// Mypy's overlapping overload logic misses these issues (see mypy
Expand Down
6 changes: 4 additions & 2 deletions pyrightconfig.stricter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@
"reportUntypedNamedTuple": "error",
"reportPrivateUsage": "none",
"reportConstantRedefinition": "error",
"reportIncompatibleMethodOverride": "error",
"reportIncompatibleVariableOverride": "error",
"reportInvalidStringEscapeSequence": "error",
"reportUnknownParameterType": "error",
"reportUnknownArgumentType": "error",
Expand All @@ -113,6 +111,10 @@
"reportPropertyTypeMismatch": "error",
"reportSelfClsParameterName": "error",
"reportUnsupportedDunderAll": "error",
// Incompatible overrides are out of typeshed's control as they are
// inherited from the implementation.
"reportIncompatibleMethodOverride": "none",
"reportIncompatibleVariableOverride": "none",
// Overlapping overloads cannot be enabled at this time because
// of the "fractions.Fraction.__pow__" method and "tasks.gather" function.
// Mypy's overlapping overload logic misses these issues (see mypy
Expand Down
4 changes: 1 addition & 3 deletions stubs/SQLAlchemy/sqlalchemy/dialects/mssql/pyodbc.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ class MSExecutionContext_pyodbc(MSExecutionContext):
def pre_exec(self) -> None: ...
def post_exec(self) -> None: ...

# pyright complains about incompatible definitions of "supports_sane_rowcount_returning" in the base classes,
# hence the type: ignore
class MSDialect_pyodbc(PyODBCConnector, MSDialect): # type: ignore
class MSDialect_pyodbc(PyODBCConnector, MSDialect):
supports_statement_cache: bool
supports_sane_rowcount_returning: bool
colspecs: Any
Expand Down
4 changes: 1 addition & 3 deletions stubs/SQLAlchemy/sqlalchemy/dialects/mysql/pyodbc.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ class _pyodbcTIME(TIME):
class MySQLExecutionContext_pyodbc(MySQLExecutionContext):
def get_lastrowid(self): ...

# pyright complains about incompatible definitions of "supports_sane_rowcount_returning" variable in the base classes,
# hence the type: ignore
class MySQLDialect_pyodbc(PyODBCConnector, MySQLDialect): # type: ignore
class MySQLDialect_pyodbc(PyODBCConnector, MySQLDialect):
supports_statement_cache: bool
colspecs: Any
supports_unicode_statements: bool
Expand Down
4 changes: 1 addition & 3 deletions stubs/SQLAlchemy/sqlalchemy/dialects/postgresql/hstore.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ import sqlalchemy.types as sqltypes

from ...sql import functions as sqlfunc

# pyright complains that "Comparator" is defined incompatibly in the base classes,
# hence the type: ignore
class HSTORE(sqltypes.Indexable, sqltypes.Concatenable, sqltypes.TypeEngine): # type: ignore
class HSTORE(sqltypes.Indexable, sqltypes.Concatenable, sqltypes.TypeEngine):
__visit_name__: str
hashable: bool
text_type: Any
Expand Down
22 changes: 9 additions & 13 deletions stubs/SQLAlchemy/sqlalchemy/sql/sqltypes.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
# pyright complains that several classes in this file
# have incompatible definitions of the "Comparator" variable in their bases,
# meaning there are several type: ignores

from typing import Any

from .base import SchemaEventTarget
Expand All @@ -28,7 +24,7 @@ class Indexable:
def __getitem__(self, index): ...
comparator_factory: Any

class String(Concatenable, TypeEngine): # type: ignore
class String(Concatenable, TypeEngine):
__visit_name__: str
RETURNS_UNICODE: Any
RETURNS_BYTES: Any
Expand Down Expand Up @@ -63,7 +59,7 @@ class UnicodeText(Text):
__visit_name__: str
def __init__(self, length: Any | None = ..., **kwargs) -> None: ...

class Integer(_LookupExpressionAdapter, TypeEngine): # type: ignore
class Integer(_LookupExpressionAdapter, TypeEngine):
__visit_name__: str
def get_dbapi_type(self, dbapi): ...
@property
Expand All @@ -76,7 +72,7 @@ class SmallInteger(Integer):
class BigInteger(Integer):
__visit_name__: str

class Numeric(_LookupExpressionAdapter, TypeEngine): # type: ignore
class Numeric(_LookupExpressionAdapter, TypeEngine):
__visit_name__: str
precision: Any
scale: Any
Expand All @@ -101,21 +97,21 @@ class Float(Numeric):
def __init__(self, precision: Any | None = ..., asdecimal: bool = ..., decimal_return_scale: Any | None = ...) -> None: ...
def result_processor(self, dialect, coltype): ...

class DateTime(_LookupExpressionAdapter, TypeEngine): # type: ignore
class DateTime(_LookupExpressionAdapter, TypeEngine):
__visit_name__: str
timezone: Any
def __init__(self, timezone: bool = ...) -> None: ...
def get_dbapi_type(self, dbapi): ...
@property
def python_type(self): ...

class Date(_LookupExpressionAdapter, TypeEngine): # type: ignore
class Date(_LookupExpressionAdapter, TypeEngine):
__visit_name__: str
def get_dbapi_type(self, dbapi): ...
@property
def python_type(self): ...

class Time(_LookupExpressionAdapter, TypeEngine): # type: ignore
class Time(_LookupExpressionAdapter, TypeEngine):
__visit_name__: str
timezone: Any
def __init__(self, timezone: bool = ...) -> None: ...
Expand Down Expand Up @@ -203,7 +199,7 @@ class Boolean(Emulated, TypeEngine, SchemaType): # type: ignore[misc]
def bind_processor(self, dialect): ...
def result_processor(self, dialect, coltype): ...

class _AbstractInterval(_LookupExpressionAdapter, TypeEngine): # type: ignore
class _AbstractInterval(_LookupExpressionAdapter, TypeEngine):
def coerce_compared_value(self, op, value): ...

class Interval(Emulated, _AbstractInterval, TypeDecorator): # type: ignore[misc]
Expand All @@ -220,7 +216,7 @@ class Interval(Emulated, _AbstractInterval, TypeDecorator): # type: ignore[misc
def bind_processor(self, dialect): ...
def result_processor(self, dialect, coltype): ...

class JSON(Indexable, TypeEngine): # type: ignore
class JSON(Indexable, TypeEngine):
__visit_name__: str
hashable: bool
NULL: Any
Expand Down Expand Up @@ -255,7 +251,7 @@ class JSON(Indexable, TypeEngine): # type: ignore
def bind_processor(self, dialect): ...
def result_processor(self, dialect, coltype): ...

class ARRAY(SchemaEventTarget, Indexable, Concatenable, TypeEngine): # type: ignore
class ARRAY(SchemaEventTarget, Indexable, Concatenable, TypeEngine):
__visit_name__: str
zero_indexes: bool

Expand Down